Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CFE_ES_ERR_BUFFER to CFE_ES_BAD_ARGUMENT #1269

Closed
zanzaben opened this issue Mar 26, 2021 · 0 comments · Fixed by #1268 or #1258
Closed

Refactor CFE_ES_ERR_BUFFER to CFE_ES_BAD_ARGUMENT #1269

zanzaben opened this issue Mar 26, 2021 · 0 comments · Fixed by #1268 or #1258
Assignees
@zanzaben
Labels
enhancement
Milestone
Caelum

Comments

@zanzaben
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Most functions return Bad_argument when they get a null pointer but a few stragglers still use buffer.

Describe the solution you'd like
They should all be consistent and return the same error.

Additional context
This is something that should have been done for #547

Requester Info
Alex Campbell GSFC
@zanzaben zanzaben self-assigned this Mar 26, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Mar 26, 2021
@zanzaben
Fix nasa#1269, refactor CFE_ES_ERR_BUFFER to CFE_ES_BAD_ARGUMENT
fe95bec
@zanzaben zanzaben mentioned this issue Mar 26, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Mar 30, 2021
@astrogeco astrogeco mentioned this issue Mar 30, 2021
Merged
astrogeco added a commit that referenced this issue Mar 30, 2021
@astrogeco
Merge pull request #1271 from zanzaben/fix1267_GetAppId_null_pointer
db39522 
Fix #1267, add null pointer check
Fix #1269, refactor CFE_ES_ERR_BUFFER to CFE_ES_BAD_ARGUMENT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@zanzaben @skliper