cFE Integration candidate: 2021-03-30

[astrogeco]

Describe the contribution
Fix #1180, Removes impossible conditions
Fix #1002, Remove deprecated elements
Fix #1252, Squash potentially uninitialized variable warnings
Fix #1185, Squash possible uninitialized variable false alarms
Fix #1246, Typo in CFE_TBL_Validate AppName
Fix #1192, Initialize TotalMsgSize in CFE_SB_GetUserDataLength
Fix #1187, Increment CreatePipeErrorCounter for all create pipe errors
Fix #1186, Remove useless assignments/checks
Fix #1239, scrub include header guards
Fix #1194, check for NULL in SlotUsed helpers
Fix #1261, removed redundant checks for CFE_SUCCESS
Fix #1215, remove task registration calls
Fix #1223, shorten TestRunner function name
Fix #1264, Convert functional test startup script example to use "simple" filenames
Fix #1164, use FS file name parser for commands
Fix #1155, clean up zero copy API
Fix #1181, global variable cleanup
Fix #1206, report PSP version in ES HK TLM
Fix #1270, limit check in pool validation
Fix #1267, add null pointer check
Fix #1269, replace CFE_ES_ERR_BUFFER return for invalid null pointer arguments
Fix #1259, adds --branch-coverage option to genhtml line in lcov Makefile rule

Testing

cFE Tests https://github.com/nasa/cFE/pull/1258/checks
bundle tests https://github.com/nasa/cFS/pull/227/checks

Behavior Changes

PR #1237

Removes cases in cfe_es_apps.c and cfe_tbl_internal.c that could never hit the alternate condition since the condition was already checked

PR #1240

Removes all APIs deprecated in #777 and #998

PR #1253

Resolves CodeQL warnings on uninitialized variables.

PR #1241

Refactors a small portion of CFE_TIME_UnregisterSynchCallback and initializes variables to resolve "uninitialized variable" false alarms.

PR #1247

Fixes a typo in initialization in CFE_TBL_Validate( CFE_TBL_Handle_t TblHandle )

PR #1234

Initializes TotalMsgSize as 0 to avoid static analysis warning of "use before initialized"

PR #1245

Increments the CreatePipeErrorCounter for all create pipe errors to eliminate a trivial static analysis warning

PR #1236

Removes redundant or unreachable assignments and checks

PR #1262

Updates header guards to standard format. Converts some file-scope block comments to a doxygen format to include a summary of the file.

PR #1256

Enables the internal helper functions that determine table slot availability to handle NULL pointers.

PR #1263

Resolves static analysis warnings by removing redundant check for CFE_SUCCESS in CFE_EVS_EarlyInit

PR #1250

This API change affects cFS apps. Moves the invocation of CFE_PSP_AttachExceptions() from the registration function to the pre-entry function and removes all references to task registration in code, docs, and tests.

PR #1242

Renames CFE_TestRunner_AppMain as CFE_TR_AppMain so it is less than 20 characters long. Updates App file names in documentation for cfe_es_startup.scr.

PR #1229

Replace the call to CFE_SB_MessageStringGet() with the new filename-aware function CFE_FS_ParseInputFileName() for commands that contain file names like CFE_ES_StopPerfDataCmd. The default pathname/extension logic is now applied here too and only a "basename" is strictly necessary, although if a full/absolute path is given, it will be used as is.

PR #1257

Removes the now-unnecessary CFE_SB_ZeroCopyHandle_t type and all APIs that refer or require it .Replaces CFE_SB_ZeroCopyGetPtr() and CFE_SB_ZeroCopyReleasePtr() with two new simplified functions CFE_SB_AllocateMessageBuffer() and CFE_SB_ReleaseMessageBuffer() , respectively. These new functions do not use a separate handle. Updates the CFE_SB_TransmitBuffer() API to also remove the handle. Does affect public APIs.

PR #1254

Internal cleanup localized to ES implementation. Consolidate all ES global variables under the CFE_ES_Global struct. Removes the separate CFE_ES_TaskData and some random pointers that were stored at global scope. Adjusts all references to the deprecated items accordingly (search and replace).

PR #1255

Adds PSP version info to ES Housekeeping TLM messages. Changes both PSP and OSAL version info assignments on HK TLM to use the new version info API.

PR #1271

Fixes check for "NumBuckets" member to use <= instead of <. CFE_ES_GenPoolValidateState() now returns true if using the max number of buckets (17 by default) and the pool structure using max value will correctly validate

PR #1268

Replaces remaining CFE_ES_ERR_BUFFER with CFE_ES_BAD_ARGUMENT for when functions receive an invalid null-pointer argument. Adds null pointer checks in cfe_es_api.c.

PR #1260

Adds branch coverage to html report when running make lcov

Additional Context

Part of nasa/cFS#227

Authors

@skliper
@jphickey
@zanzaben
@astrogeco