Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define file subtype value behavior/expectations #1394

Closed
skliper opened this issue Apr 20, 2021 · 3 comments · Fixed by #1575 or #1584
Closed

Define file subtype value behavior/expectations #1394

skliper opened this issue Apr 20, 2021 · 3 comments · Fixed by #1575 or #1584

Comments

@skliper
Copy link
Contributor

skliper commented Apr 20, 2021

Is your feature request related to a problem? Please describe.
Not clear if the CFE_FS_InitHeader SubType needs to be one of the FS enums or if it can be user defined by apps. Note there is no longer a shell file created by ES:

/**
* @brief Executive Services Shell Response File
*
* Executive Services Shell Response Data File which is generated in response to a
* shell command.
*
*/
CFE_FS_SubType_ES_SHELL = 5,

Describe the solution you'd like
Need to determine if FS should define all file subtypes, or treat it as an extendable field (or whatever). That will affect if the SHELL subtype gets removed or renamed (since there is still an app that would create it). Note right now apps don't even use CFE_FS_InitHeader, but they do currently set unique values.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Apr 20, 2021
@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 20, 2021
@skliper
Copy link
Contributor Author

skliper commented Apr 20, 2021

Ping @ejtimmon

@astrogeco
Copy link
Contributor

CCB:2021-04-21 DISCUSSED

@skliper
Copy link
Contributor Author

skliper commented Apr 21, 2021

The SubTypes defined within the cFE FS header are cFS framework only, and apps are allowed to extend. Could be future work issue to add app context to the header to avoid conflict.

@skliper skliper removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 21, 2021
@skliper skliper self-assigned this May 25, 2021
skliper added a commit to skliper/cFE that referenced this issue May 25, 2021
astrogeco added a commit that referenced this issue May 27, 2021
Fix #1394, Remove shell file subtype and clarify scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants