cFE Integration candidate: 2021-06-01 #1584

Adds "nonnull", "nonzero", and "covtest" tags to mark parameters and return values in documentation. This info is helpful when auditing the test cases.

Instead of including the OSAL API guide templates and pages in the CFE repo, invoke the build script now provided in the OSAL repo itself.

- Removed requirement cEVS3101 - Removed documentation references - Removed from API header - Removed stub - Removed implementation - Removed coverage test

- Updated CFE_ES_QueryAllCmd handler - Updated CFE_ES_QueryAllTasksCmd handler

Fix #1364, Update ES verify errors to match test

Fix #1366, Resolve mismatched endforeach of CMakeList.txt

Fix #1390, Improve event filter documentation

Fix #1391, EVS/FS documentation cleanup

Fix #1394, Remove shell file subtype and clarify scope

Fix #1362, Simplify CFE_ES_QueryAllCmd file open logic

Fix #1423, Remove deprecated elements

Fix #1476, Use CFE_MSG_SequenceCount_t for seqcnt type

Fix #1485, Document CFE_ES_PoolCreateEx NumBlockSizes error handling

Fix #1494, Documentation cleanup in TBL/TIME

Fix #1507, Document TblName as app specific

nasa/cFE#1584 Includes: nasa/cFE#1580, Update ES verify errors to match test nasa/cFE#1578, Resolve mismatched endforeach of CMakeList.txt nasa/cFE#1579, Improve event filter documentation nasa/cFE#1576, EVS/FS documentation cleanup nasa/cFE#1575, Remove shell file subtype and clarify scope nasa/cFE#1582, Simplify file open/truncate logic nasa/cFE#1567, Remove deprecated elements nasa/cFE#1556, Replace Header Content Type magic number nasa/cFE#1553, Remove unused EVS LogMode defines nasa/cFE#1570, Document cleanup from SB/MSG/SBR review, Remove unused CFE_SB_NO_SUBSCRIBERS nasa/cFE#1565, Add CFE_SB_DestinationD tag and use for pointers nasa/cFE#1564, Use CFE_MSG_SequenceCount_t for seqcnt type nasa/cFE#1562, Document CFE_ES_PoolCreateEx NumBlockSizes error handling nasa/cFE#1560, Documentation cleanup in TBL/TIME nasa/cFE#1558, Document TblName as app specific

Fix #1561, use OSAL script to generate API guide

#263 Combines nasa/cFE#1584 nasa/osal#1058 Includes: nasa/cFE#1563, use OSAL script to generate API guide nasa/osal#1033, include doxygen targets locally

HOTFIX, `CFE_ES_CDS_REGISTRY_FULL` is deprecated

nasa/cFE#1584 Includes: nasa/cFE#1580, Update ES verify errors to match test nasa/cFE#1578, Resolve mismatched endforeach of CMakeList.txt nasa/cFE#1579, Improve event filter documentation nasa/cFE#1576, EVS/FS documentation cleanup nasa/cFE#1575, Remove shell file subtype and clarify scope nasa/cFE#1582, Simplify file open/truncate logic nasa/cFE#1567, Remove deprecated elements nasa/cFE#1556, Replace Header Content Type magic number nasa/cFE#1553, Remove unused EVS LogMode defines nasa/cFE#1570, Document cleanup from SB/MSG/SBR review, Remove unused CFE_SB_NO_SUBSCRIBERS nasa/cFE#1565, Add CFE_SB_DestinationD tag and use for pointers nasa/cFE#1564, Use CFE_MSG_SequenceCount_t for seqcnt type nasa/cFE#1562, Document CFE_ES_PoolCreateEx NumBlockSizes error handling nasa/cFE#1560, Documentation cleanup in TBL/TIME nasa/cFE#1558, Document TblName as app specific

#263 Combines nasa/cFE#1584 nasa/osal#1058 Includes: nasa/cFE#1563, use OSAL script to generate API guide nasa/osal#1033, include doxygen targets locally

Fix #1548, Include verify headers to validate config

Updates nasa/cFE#1584 and nasa/osal#1058 Includes nasa/osal#962, update OSAL Config Guide link nasa/cFE#1557, Include verify headers to validate config

…d-codeql Fix #1512, Add Coding Standard Rules in CodeQL

Fix #1585, Fix Calculate CRC header return description.

Fix #1435, Consistent use of uint16 for EventID

Fix #1386, Remove CFE_EVS_Unregister API

astrogeco · 2021-06-03T15:01:31Z

@jphickey getting a strange cmake error in the CodeQL workflows

CMake Error at cmake/arch_build.cmake:45 (file): file failed to open for reading (No such file or directory):

Run cp ./cfe/cmake/Makefile.sample Makefile
mkdir -p "build"
(cd "build" && cmake  -DCMAKE_INSTALL_PREFIX=/exe -DCMAKE_BUILD_TYPE=release "/home/runner/work/cFE/cFE/cfe")
-- The C compiler identification is GNU 7.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Mission configuration sample automatically selected
-- OMIT_DEPRECATED=true: Not including deprecated elements in build
-- Search path for modules: apps;libs;psp/fsw/modules;cfe/modules
-- Module 'core_api' found at /home/runner/work/cFE/cFE/cfe/modules/core_api
-- Module 'core_private' found at /home/runner/work/cFE/cFE/cfe/modules/core_private
-- Module 'ci_lab' found at /home/runner/work/cFE/cFE/apps/ci_lab
-- Module 'to_lab' found at /home/runner/work/cFE/cFE/apps/to_lab
-- Module 'sch_lab' found at /home/runner/work/cFE/cFE/apps/sch_lab
-- Module 'cfe_assert' found at /home/runner/work/cFE/cFE/cfe/modules/cfe_assert
-- Module 'cfe_testcase' found at /home/runner/work/cFE/cFE/cfe/modules/cfe_testcase
-- Module 'sample_app' found at /home/runner/work/cFE/cFE/apps/sample_app
-- Module 'sample_lib' found at /home/runner/work/cFE/cFE/apps/sample_lib
-- Module 'es' found at /home/runner/work/cFE/cFE/cfe/modules/es
-- Module 'evs' found at /home/runner/work/cFE/cFE/cfe/modules/evs
-- Module 'fs' found at /home/runner/work/cFE/cFE/cfe/modules/fs
-- Module 'sb' found at /home/runner/work/cFE/cFE/cfe/modules/sb
-- Module 'tbl' found at /home/runner/work/cFE/cFE/cfe/modules/tbl
-- Module 'time' found at /home/runner/work/cFE/cFE/cfe/modules/time
-- Module 'osal' found at /home/runner/work/cFE/cFE/osal
-- Module 'psp' found at /home/runner/work/cFE/cFE/psp
-- Module 'msg' found at /home/runner/work/cFE/cFE/cfe/modules/msg
-- Module 'sbr' found at /home/runner/work/cFE/cFE/cfe/modules/sbr
-- Module 'resourceid' found at /home/runner/work/cFE/cFE/cfe/modules/resourceid
CMake Error at cmake/mission_build.cmake:314 (add_subdirectory):
  add_subdirectory given source "/home/runner/work/cFE/cFE/osal/doc/src"
  which is not an existing directory.
Call Stack (most recent call first):
  CMakeLists.txt:120 (prepare)


-- Configuring for system arch: native/default_cpu1
-- The C compiler identification is GNU 7.5.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at cmake/arch_build.cmake:45 (file):
  file failed to open for reading (No such file or directory):

Fix #1554, add doxygen aliases for OSAL parameter/retvals NOTE: Manually merged/propagated to CFE-common resolve warnings when referencing OSAL headers from CFE usersguide build.

astrogeco · 2021-06-04T17:32:17Z

CMake Error at cmake/arch_build.cmake:45 (file):
  file failed to open for reading (No such file or directory):

    /home/runner/work/cFE/cFE/build/mission_vars.cache
Call Stack (most recent call first):
  CMakeLists.txt:87 (initialize_globals)

Combines: nasa/osal#1058 nasa/cFE#1584 nasa/sch_lab#82 Includes: nasa/sch_lab#81, exit the main loop if init fails nasa/cFE#1555, add doxygen aliases for OSAL parameter/retvals nasa/osal HOTFIX

nasa/cFE#1584 v6.8.0-rc1+dev642 nasa/osal#1058 v5.1.0-rc1+dev500 nasa/sch_lab#82 v2.4.0-rc1+dev36

- #263, bundle Combines: - nasa/cFE#1584, v6.8.0-rc1+dev642 - nasa/osal#1058, v5.1.0-rc1+dev500 - nasa/sch_lab#82, v2.4.0-rc1+dev36 Includes: - nasa/cFE#1580, Update ES verify errors to match test - nasa/cFE#1578, Resolve mismatched endforeach of CMakeList.txt - nasa/cFE#1579, Improve event filter documentation - nasa/cFE#1576, EVS/FS documentation cleanup - nasa/cFE#1575, Remove shell file subtype and clarify scope - nasa/cFE#1582, Simplify file open/truncate logic - nasa/cFE#1567, Remove deprecated elements - nasa/cFE#1556, Replace Header Content Type magic number - nasa/cFE#1553, Remove unused EVS LogMode defines - nasa/cFE#1570, Document cleanup from SB/MSG/SBR review, Remove unused CFE_SB_NO_SUBSCRIBERS - nasa/cFE#1565, Add CFE_SB_DestinationD tag and use for pointers - nasa/cFE#1564, Use CFE_MSG_SequenceCount_t for seqcnt type - nasa/cFE#1562, Document CFE_ES_PoolCreateEx NumBlockSizes error handling - nasa/cFE#1560, Documentation cleanup in TBL/TIME - nasa/cFE#1558, Document TblName as app specific - nasa/cFE#1563, use OSAL script to generate API guide - nasa/cFE#1557, Include verify headers to validate config - nasa/cFE#1555, add doxygen aliases for OSAL parameter/retvals - nasa/osal#1033, include doxygen targets locally - nasa/osal#1031, Document OS_ObjectIdToArrayIndex as public - nasa/osal#1040, resolve discrepancies between binsem API and unit tests - nasa/osal#1029, add missing clock retcode tests - nasa/osal#1046, resolve discrepancies between common API and unit tests - nasa/osal#1041, resolve discrepancies between countsem API and unit tests - nasa/osal#1045, resolve discrepancies between dir API and unit tests - nasa/osal#1043, resolve discrepancies between module API and unit tests - nasa/osal#1044, resolve discrepancies between mutex API and unit tests - nasa/osal#1038, resolve discrepancies between queue API and unit tests - nasa/osal#1037, resolve discrepancies between task API and unit tests - nasa/osal#1051, resolve discrepancies between timebase API and unit tests - nasa/osal#1030, check misc API return codes - nasa/osal#1039, Rename CodeQL cFE Build and add Duplicate Job - nasa/osal#1049, filter only whole words for keyword match - nasa/osal#962, update OSAL Config Guide link - nasa/sch_lab#81, exit the main loop if init fails - HOTFIX cFS-bundle, Use new osalguide logfile to fix documentation build workflow errors,

- #263, bundle Combines: - nasa/cFE#1584, v6.8.0-rc1+dev642 - nasa/osal#1058, v5.1.0-rc1+dev500 - nasa/sch_lab#82, v2.4.0-rc1+dev36 Includes: - nasa/cFE#1580, Update ES verify errors to match test - nasa/cFE#1578, Resolve mismatched endforeach of CMakeList.txt - nasa/cFE#1579, Improve event filter documentation - nasa/cFE#1576, EVS/FS documentation cleanup - nasa/cFE#1575, Remove shell file subtype and clarify scope - nasa/cFE#1582, Simplify file open/truncate logic - nasa/cFE#1567, Remove deprecated elements - nasa/cFE#1556, Replace Header Content Type magic number - nasa/cFE#1553, Remove unused EVS LogMode defines - nasa/cFE#1570, Document cleanup from SB/MSG/SBR review, Remove unused CFE_SB_NO_SUBSCRIBERS - nasa/cFE#1565, Add CFE_SB_DestinationD tag and use for pointers - nasa/cFE#1564, Use CFE_MSG_SequenceCount_t for seqcnt type - nasa/cFE#1562, Document CFE_ES_PoolCreateEx NumBlockSizes error handling - nasa/cFE#1560, Documentation cleanup in TBL/TIME - nasa/cFE#1558, Document TblName as app specific - nasa/cFE#1563, use OSAL script to generate API guide - nasa/cFE#1557, Include verify headers to validate config - nasa/cFE#1555, add doxygen aliases for OSAL parameter/retvals - nasa/osal#1033, include doxygen targets locally - nasa/osal#1031, Document OS_ObjectIdToArrayIndex as public - nasa/osal#1040, resolve discrepancies between binsem API and unit tests - nasa/osal#1029, add missing clock retcode tests - nasa/osal#1046, resolve discrepancies between common API and unit tests - nasa/osal#1041, resolve discrepancies between countsem API and unit tests - nasa/osal#1045, resolve discrepancies between dir API and unit tests - nasa/osal#1043, resolve discrepancies between module API and unit tests - nasa/osal#1044, resolve discrepancies between mutex API and unit tests - nasa/osal#1038, resolve discrepancies between queue API and unit tests - nasa/osal#1037, resolve discrepancies between task API and unit tests - nasa/osal#1051, resolve discrepancies between timebase API and unit tests - nasa/osal#1030, check misc API return codes - nasa/osal#1039, Rename CodeQL cFE Build and add Duplicate Job - nasa/osal#1049, filter only whole words for keyword match - nasa/osal#962, update OSAL Config Guide link - nasa/sch_lab#81, exit the main loop if init fails - HOTFIX cFS-bundle, Use new osalguide logfile to fix documentation build workflow errors, Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Jake Hageman skliper <skliper@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Ross Peters <rosspeters6@users.noreply.github.com>

pepepr08 and others added 30 commits May 18, 2021 14:43

Fix #1446, Remove unused EVS LogMode defines

6de6d24

Fix #1554, add doxygen aliases for OSAL parameter/retvals

41dff63

Adds "nonnull", "nonzero", and "covtest" tags to mark parameters and return values in documentation. This info is helpful when auditing the test cases.

Fix #1441, Replace Header Content Type magic number.

be1d5d5

Fix #1548, Include verify headers to validate config

849eed3

Fix #1507, Document TblName as app specific

18152c3

Fix #1494, Documentation cleanup in TBL/TIME

202c122

Fix #1485, Document CFE_ES_PoolCreateEx NumBlockSizes error handling

ee19f18

Fix #1561, use OSAL script to generate API guide

a98d831

Instead of including the OSAL API guide templates and pages in the CFE repo, invoke the build script now provided in the OSAL repo itself.

Fix #1561, also remove dox files now in OSAL

2e0bc9f

Fix #1476, Use CFE_MSG_SequenceCount_t for seqcnt type

6333d25

Fix #1455, Add CFE_SB_DestinationD tag and use for pointers

8c84e57

Fix #1423, Remove deprecated elements

4652c0d

Fix #1435, Consistent use of uint16 for EventID

d7c2b24

Fix #1394, Remove shell file subtype and clarify scope

6ce0230

Fix #1391, EVS/FS documentation cleanup

b9aa9ca

Fix #1386, Remove CFE_EVS_Unregister API

8280c27

- Removed requirement cEVS3101 - Removed documentation references - Removed from API header - Removed stub - Removed implementation - Removed coverage test

Fix #1366, Resolve mismatched endforeach of CMakeList.txt

8128384

Fix #1390, Improve event filter documentation

18e4d06

Fix #1364, Update ES verify errors to match test

251267a

Fix #1569, Remove unused CFE_SB_NO_SUBSCRIBERS

ee6c43d

Fix #1452, Document cleanup from SB/MSG/SBR review

d6c0091

Fix #1362, Simplify file open/truncate logic

560111c

- Updated CFE_ES_QueryAllCmd handler - Updated CFE_ES_QueryAllTasksCmd handler

Fix #1512, Add Coding Standard Rules in CodeQL

13eb53f

Merge pull request #1580 from skliper/fix1364-es_verify_errors

b7bfaba

Fix #1364, Update ES verify errors to match test

Merge pull request #1578 from skliper/fix1366-mismatch_endforeach

41d6eaa

Fix #1366, Resolve mismatched endforeach of CMakeList.txt

Merge pull request #1579 from skliper/fix1390-event_filter_doc

6d8b907

Fix #1390, Improve event filter documentation

Merge pull request #1576 from skliper/fix1391-evs_fs_doc_cleanup

de3af04

Fix #1391, EVS/FS documentation cleanup

Merge pull request #1575 from skliper/fix1394-file_subtype

5febad7

Fix #1394, Remove shell file subtype and clarify scope

Merge pull request #1582 from skliper/fix1362-open_truncate

2a93eaf

Fix #1362, Simplify CFE_ES_QueryAllCmd file open logic

Merge pull request #1567 from skliper/fix1423-remove_deprecated

7f08fc3

Fix #1423, Remove deprecated elements

astrogeco added 4 commits May 27, 2021 12:25

Merge pull request #1564 from skliper/fix1476-sequencecounttype

b1f36ee

Fix #1476, Use CFE_MSG_SequenceCount_t for seqcnt type

Merge pull request #1562 from skliper/fix1485-numblocksize_error_doc

efd72a0

Fix #1485, Document CFE_ES_PoolCreateEx NumBlockSizes error handling

Merge pull request #1560 from skliper/fix1494-tbltime_doc_cleanup

1344f7f

Fix #1494, Documentation cleanup in TBL/TIME

Merge pull request #1558 from skliper/fix1507-tblname_processor_specific

3fdecc6

Fix #1507, Document TblName as app specific

astrogeco added the IC:2021-06-01 label May 27, 2021

astrogeco mentioned this pull request May 27, 2021

cFS Bundle Integration Candidate: 2021-06-01 nasa/cFS#263

Merged

Merge pull request #1563 from jphickey/fix-1561-osal-apiguide

d71583a

Fix #1561, use OSAL script to generate API guide

astrogeco added a commit to nasa/cFS that referenced this pull request May 27, 2021

IC:2021-06-01, osalguide doxygen migration

e9f8501

#263 Combines nasa/cFE#1584 nasa/osal#1058 Includes: nasa/cFE#1563, use OSAL script to generate API guide nasa/osal#1033, include doxygen targets locally

astrogeco and others added 2 commits May 27, 2021 13:12

IC:2021-06-01, Remove deprecated doxygen reference

acea60e

HOTFIX, `CFE_ES_CDS_REGISTRY_FULL` is deprecated

Fix #1585, Fix Calculate CRC header return description.

16196d4

astrogeco added a commit to nasa/cFS that referenced this pull request Jun 1, 2021

IC:2021-06-01, osalguide doxygen migration

7a93613

#263 Combines nasa/cFE#1584 nasa/osal#1058 Includes: nasa/cFE#1563, use OSAL script to generate API guide nasa/osal#1033, include doxygen targets locally

Merge pull request #1557 from skliper/fix1548-include_verify

df3d75f

Fix #1548, Include verify headers to validate config

astrogeco added a commit to nasa/cFS that referenced this pull request Jun 2, 2021

IC:2021-06-01, Add cFE PRs and osal community PR

c5f3766

Updates nasa/cFE#1584 and nasa/osal#1058 Includes nasa/osal#962, update OSAL Config Guide link nasa/cFE#1557, Include verify headers to validate config

astrogeco added 4 commits June 2, 2021 11:12

Merge pull request #1513 from ArielSAdamsNASA/fix-1512-coding-standar…

41d552c

…d-codeql Fix #1512, Add Coding Standard Rules in CodeQL

Merge pull request #1591 from zanzaben/fix1585_fix_crc_header

2d97cb2

Fix #1585, Fix Calculate CRC header return description.

Merge pull request #1572 from skliper/fix1435-eventid_type

00d1a39

Fix #1435, Consistent use of uint16 for EventID

Merge pull request #1577 from skliper/fix1386-remove_evs_unregister

4a3129c

Fix #1386, Remove CFE_EVS_Unregister API

Merge pull request #1555 from jphickey/fix-1554-doc-tags

51ecd53

Fix #1554, add doxygen aliases for OSAL parameter/retvals NOTE: Manually merged/propagated to CFE-common resolve warnings when referencing OSAL headers from CFE usersguide build.

IC:2021-06-01, Bump to v6.8.0-rc1+dev642

66378f9

astrogeco marked this pull request as ready for review June 8, 2021 16:36

astrogeco added a commit to nasa/cFS that referenced this pull request Jun 8, 2021

IC:2021-06-01, Add version bumps

72fab36

nasa/cFE#1584 v6.8.0-rc1+dev642 nasa/osal#1058 v5.1.0-rc1+dev500 nasa/sch_lab#82 v2.4.0-rc1+dev36

astrogeco merged commit a16c78e into main Jun 8, 2021

skliper added this to the 7.0.0 milestone Sep 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cFE Integration candidate: 2021-06-01 #1584

cFE Integration candidate: 2021-06-01 #1584

astrogeco commented May 27, 2021 •

edited

astrogeco commented Jun 3, 2021 •

edited

astrogeco commented Jun 4, 2021

cFE Integration candidate: 2021-06-01 #1584

cFE Integration candidate: 2021-06-01 #1584

Conversation

astrogeco commented May 27, 2021 • edited

Context

Tests

Authors

Description

PR #1580

PR #1578

PR #1579

PR #1576

PR #1575

PR #1582

PR #1567

PR #1556

PR #1553

PR #1570

PR #1565

PR #1564

PR #1562

PR #1560

PR #1558

PR #1563

PR #1557

PR #1555

astrogeco commented Jun 3, 2021 • edited

astrogeco commented Jun 4, 2021

astrogeco commented May 27, 2021 •

edited

astrogeco commented Jun 3, 2021 •

edited