Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVS coverage - filter behavior failures don't get logged correctly, missing verification of latch requirement #1819

Closed
skliper opened this issue Aug 16, 2021 · 0 comments · Fixed by #1862 or #1885
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Aug 16, 2021

Is your feature request related to a problem? Please describe.
Filter verification is done by sending an event message that says "FAILED", even though the actual assert will PASS. This does not get counted in test reporting as an actual failure.

/* Send 2nd information message, should be filtered */
UT_InitData();
CFE_UtAssert_SUCCESS(CFE_EVS_SendEvent(0, CFE_EVS_EventType_INFORMATION, "FAILED"));
/* Send last information message, which should cause filtering to lock */
UT_InitData();
FilterPtr = EVS_FindEventID(0, (EVS_BinFilter_t *)AppDataPtr->BinFilters);
FilterPtr->Count = CFE_EVS_MAX_FILTER_COUNT - 1;
CFE_UtAssert_SUCCESS(CFE_EVS_SendEvent(0, CFE_EVS_EventType_INFORMATION, "OK"));
/* Test that filter lock is applied */
UT_InitData();
CFE_UtAssert_SUCCESS(CFE_EVS_SendEvent(0, CFE_EVS_EventType_INFORMATION, "FAILED"));
/* Test that filter lock is (still) applied */
UT_InitData();
CFE_UtAssert_SUCCESS(CFE_EVS_SendEvent(0, CFE_EVS_EventType_INFORMATION, "FAILED"));

Describe the solution you'd like
Assert on the message counters not incrementing (MessageSendCounter and/or EventCount) and CFE_SB_TransmitMsg stub count doesn't increment, the as well as the filter counter (should latch at max per requirement).

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the 7.0.0 milestone Aug 16, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 20, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Aug 24, 2021
astrogeco added a commit that referenced this issue Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants