ES missing branch coverage in CFE_ES_RunPerfLogDump, condition not possible

[skliper]

Is your feature request related to a problem? Please describe.
There's no way for the current state to not be < CFE_ES_PerfDumpState_CLEANUP:

     481         [ +  - ]:          1 :                     if (State->CurrentState < CFE_ES_PerfDumpState_CLEANUP)
     482                 :            :                     {
     483                 :          1 :                         State->PendingState = CFE_ES_PerfDumpState_CLEANUP;
     484                 :            :                     }

here:

cFE/modules/es/fsw/src/cfe_es_perf.c

Lines 480 to 484 in e5d4ed9

	/* skip to cleanup */
	if (State->CurrentState < CFE_ES_PerfDumpState_CLEANUP)
	{
	State->PendingState = CFE_ES_PerfDumpState_CLEANUP;
	}

Describe the solution you'd like
Maybe this is an artifact of a previous implementation? Really could just set the pending state to cleanup.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

[avan989]

code coverage is not possible.

To enter this code block requires the BlockSize != 0. The only way for the BlockSize != 0 is if the State->CurrentState is ...HDR, ...METADATA, ... ENTRIES. Each of those "STATE" is less than "CFE_ES_PerfDumpState_CLEANUP". Not possible to make the non-success case for the if statement.