Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table-building scripts should be controlled with the table tool, not CFE #2483

Closed
jphickey opened this issue Dec 14, 2023 · 0 comments · Fixed by #2486
Closed

Table-building scripts should be controlled with the table tool, not CFE #2483

jphickey opened this issue Dec 14, 2023 · 0 comments · Fixed by #2486
Assignees

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The table building logic - i.e. the contents of cmake/tables directory here, along with business logic within of the add_cfe_tables function that calls the scripts and invokes the tool - are really dependent on the implementation of the table conversion tool (e.g. elf2cfetbl). A different tool will likely need different logic; the whole process of compiling into an ELF object and extracting that is really specific to the way elf2cfetbl works.

Describe the solution you'd like
The scripts and logic to compile a table and invoke the tool should really be version controlled with the table tool itself, not with CFE.

Describe alternatives you've considered
N/A

Additional context
Any time the table build procedure needs to be updated, it likely requires changes to the script in coordination with changes to the tool itself. Having the scripts with the tool just makes more sense in allowing those changes to be done atomically in one repo.

Also note that EDS uses a different tool to build tables - and required sprinkling if(CFE_EDS_ENABLED_BUILD) in a bunch of places in the add_cfe_tables() function. This would be much cleaner if the scripts were entirely separate.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant