cFE Integration candidate: 2021-04-20 #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the list of CFE core interface modules (e.g. core_api) from the list of CFE core implementation modules (e.g. msg). This allows the content of core_api to be expanded to include any additional modules the user has added to cFE core locally.
Merge the "testrunner" app and put the runner logic into cfe_assert lib. Converts the "testcase" library into an app that simply calls the logic in cfe_assert to do the test. This means that the test can be run on demand by issuing the ES start app command, rather than putting it into the startup script.
Adjust the event types so that Start/End are "info" events, not debug events (in the default platform config, debug events are not shown). Also update documentation to correct the startup script entries.
Note in the documentation for this function that it is the responsibility of the calling app to clear/fill the CDS block any time a new block is allocated.
Use a constant at the top of the file, and change the names to match current environment.
Fix #1287, split interface and implementation modules
Fix #1337, add docs to CFE_ES_RegisterCDS() regarding clearing
astrogeco
force-pushed
the
integration-candidate
branch
from
59839e3
to
3f9f7f5
Compare
Fix #1281, remove testrunner and convert testcase to app
astrogeco
force-pushed
the
integration-candidate
branch
from
c76bac8
to
066ffff
Compare
Building "cfe_assert" does not need to be conditional on ENABLE_UNIT_TESTS, it should be built all the time.
astrogeco
force-pushed
the
integration-candidate
branch
from
2419c9c
to
c96267c
Compare
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 22, 2021
Combines: nasa/cFE#1406 nasa/osal#967 nasa/cFS-GroundSystem#178 Includes: nasa/cFE#1290, Split interface and implementation modules nasa/cFE#1376, add docs to CFE_ES_RegisterCDS() regarding clearing nasa/cFE#1292, Remove testrunner and convert testcase to app cfe-IC:2021-04-20, HOTFIX: Always build cfe_assert. nasa/osal#950, Eliminate time and access name collisions with VxWorks nasa/osal#946, Fix Shell implementation on posix and rtems nasa/cFS-GroundSystem#174, update executable name and version in setup.py nasa/cFS-GroundSystem#175, Add executable install guide
zanzaben
pushed a commit
to zanzaben/cFE
that referenced
this pull request
Apr 22, 2021
cFE Integration candidate: 2021-04-20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #1290
Fix #1287, split interface and implementation modules
Separates the list of CFE core interface modules (e.g. core_api) from the list of CFE core implementation modules (e.g. msg). This allows the content of core_api to be expanded to locally include any additional modules the user has added to cFE core via the
MISSION_CORE_MODULESlist.PR #1376
Fix #1337, add docs to
CFE_ES_RegisterCDS()regarding clearingNote in the documentation for this function that it is the responsibility of the calling app to clear/fill the CDS block any time a new block is allocated.
PR #1292
Fix #1281, remove testrunner and convert testcase to app
Removes the separate CFE "testrunner" module and moves the logic associated with running a test into cfe_assert library. Converts the "testcase" module from a library into an app, by calling into the runner logic that is now inside cfe_assert. Each functional test is a separate app, not a library, so it can be started and stopped via ES command like any other app.
HOTFIX IC 2021-04-20:
Always build cfe_assert.
Building "cfe_assert" does not need to be conditional on
ENABLE_UNIT_TESTS, it should be built all the time.Additional Context
Part of nasa/cFS#248
Testing
cFE Checks https://github.com/nasa/cFE/pull/1406/checks
cFS Bundle Checks https://github.com/nasa/cFS/pull/248/checks
Authors
@jphickey