Fix #1505, accept "NULL" as entry point #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recognize the special string "NULL" to indicate no entry point should be called for the library. Equivalent to leaving the field empty.
skliper
approved these changes
May 13, 2021
jphickey
added
the
CCB:Ready
astrogeco
added
the
CCB:Approved
|
CCB:2021-05-19 APPROVED |
astrogeco
added
IC:2021-05-25
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 24, 2021
Combines: - nasa/cFE#1568 - nasa/osal#1050 Includes: - nasa/cFE#1524, add printf format casts - nasa/cFE#1520, accept "NULL" as entry point - nasa/cfe #1549, add capability to generate multiple tables - nasa/osal#1026, Add count sem timeout test
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
May 26, 2021
Combines: - cfe v6.8.0-rc1+dev593 (nasa/cFE#1568) - osal v5.1.0-rc1+dev458 (nasa/osal#1050) Includes: - nasa/cFE#1524, add printf format casts - nasa/cFE#1520, accept "NULL" as entry point - nasa/cfe #1549, add capability to generate multiple tables - nasa/cFE#1551, fixes discrepancies (return type, parameter names, etc) between function protoypes and implementation. Updates stubs accordingly - nasa/osal#1026, Add count sem timeout test - nasa/osal#1026, defer cancellation when BSP locked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Recognize the special string "NULL" to indicate no entry point should be called for the library. Equivalent to leaving the
field empty.
Fixes #1505
Testing performed
Build and sanity check CFE, and use a startup script that loads a CFE_LIB with a NULL entry point
Run all unit tests.
Expected behavior changes
Specifying the special string
NULLas the entry point in a startup script should work as it did in previous versions - skips the entry point.System(s) tested on
Ubuntu
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.