cFE Integration candidate: 2021-06-15 #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use one of the unused time state bits to indicate if an error has occurred where CFE_TIME_GetReference was not able to get a consistent copy of the reference state data. In a functional system this should never occur - there should be at most one retry, which only happens in the event there was a burst of updates (more than 4) concurrently with reading the structure. The previous implementation did not report or handle the condition at all, this at least sets a TLM status bit and returns a reference struct filled with all zeros.
Provide the UT_BSP_Lock/Unlock function to be compatible with nasa/osal#1065. The library no longer needs to be locked the entire time a test runs. This also allows test programs to be multi threaded.
- Now returning `CFE_FS_SetTimestamp` success as `CFE_SUCCESS` - `CFE_FS_SetTimestamp` now returns `CFE_STATUS_EXTERNAL_RESOURCE_FAIL` if the write doesn't return the correct bytes written - Update coverage test checks - Updated the functional test to check for `CFE_SUCCESS` vs `OS_SUCCESS` - Updated check of status in `cfe_tbl_task_cmds.c` to `CFE_SUCCESS
Put the "detaildesign" and "users_guide" into separate working directories, and do a general cleanup/simplification of the generated doxyfiles. Detail design just includes all components, and use "exclude" where special treatment was needed, and to avoid UT code. Paths for each "arch" (target-specific) are written to separate files and included directly in the generated doxyfile, reducing the number of generated files/layers.
Use a unique file name for the doxygen warnings, instead of "warnings.log", so the mutiple documentation targets will not overwrite the other log file. Use a prefixed name so that if the log file is uploaded to the build artifacts, it will be identifiable. Detail Design warnings in: detaildesign-warnings.log Users Guide warnings in: cfe-usersguide-warnings.log
Add ${ARGN} such that the user can specify multiple source files
Add a check for targets in the add_cfe_coverage_dependency, so this
can be used to add arbitrary other non-stub libraries too.
In CCB review 2021-06-09 it was agreed this might have unintended consequences/ordering dependencies so best to leave it alone.
Use "docs" instead of "doc" in both source and binary/build directory names for documentation and related files.
Fix #1483, Add CI workflow to run cFE coverage tests
Fix #1299, Updated FS Read/WriteHeader API return documentation
Fix #567, Document CFE_ES_RunLoop increment task counter behavior
Fix #1614, standardize on "docs" subdirectory
Fix #1177, Update version description per current design
Fix #741, Document CFE_TBL_Unregister use-case
Fix #1595, provide CFE assert lock/unlock
Fix #1442, Simplify CFE_FS_SetTimestamp and fix syslog typo
Fix #1308, Removed redundant check/set of CFE_CPU_ID_VALUE
Fix #1544, add time get reference error bit
Fix #1199, Add workflow to build cFE documentation
Fix #1306, ES/ResourceID documentation cleanup
Fix #1490, allow multiple sources in add_cfe_coverage_test
Fix #814, add ES Misc Functional test
…al_Tests Fix #811, add Mempool functional tests
Fix #1604, Clean/simplify version header and reporting
Fix #1378, 1589, doxygen cleanup
Fix #1325, Prepend system log messages with function name
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 17, 2021
nasa/cFE#1619 - cfe v6.8.0-rc1+dev693 nasa/osal#1076 - osal v5.1.0-rc1+dev530 nasa/PSP#296 - psp v1.5.0-rc1+dev118 *Documentation Updates:* nasa/cFE#1598, Updated FS Read/WriteHeader API return documentation nasa/cFE#1601, Document CFE_ES_RunLoop increment task counter behavior nasa/cFE#1602, Document CFE_TBL_Unregister use-case nasa/cFE#1603, Update version description per current design *Standardize docs generation:* nasa/cFE#1615, standardize on "docs" subdirectory nasa/osal#1071, rename doc to docs nasa/PSP#294, rename doc to docs *Coding Standard:* nasa/osal#1042 nasa/PSP#292 **Mutex for UTAssert** nasa/cFE#1596, provide CFE assert lock/unlock nasa/osal#1065, add mutex lock around UtAssert globals *Resolve API-UT discrepancies:* nasa/osal#1055, idmap API nasa/osal#1056, file API nasa/osal#1057, filesys API nasa/osal#1060, socket API nasa/osal#1064, select API **Other cFE ixes** nasa/cFE#1566, Simplify CFE_FS_SetTimestamp and fix syslog typo nasa/cFE#1592, Removed redundant check/set of CFE_CPU_ID_VALUE nasa/cFE#1593, add time get reference error bit nasa/cFE#1600, Add workflow to build cFE documentation nasa/cFE#1609, Requirements updates nasa/cFE#1610, ES/ResourceID documentation cleanup nasa/cFE#1613, allow multiple sources in add_cfe_coverage_test nasa/cFE#1586, add ES Misc Functional test nasa/cFE#1607, add Mempool functional tests nasa/cFE#1605, Clean/simplify version header and reporting nasa/cFE#1612, doxygen cleanup nasa/cFE#1611, Prepend system log messages with function name nasa/osal#1063, const correct OS_SelectFdIsSet nasa/osal#1073, Fix OS_Select doxygen errors nasa/osal#1073, Add missing OS_Select param doc nasa/osal#1067, Add Workflow to build and verify OSAL API Guide nasa/osal#1070, add detail design template nasa/osal#1072, Update error codes and documentation nasa/osal#1075, Increase UT object limit for testing Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jun 17, 2021
nasa/cFE#1619 - cfe v6.8.0-rc1+dev693 nasa/osal#1076 - osal v5.1.0-rc1+dev530 nasa/PSP#296 - psp v1.5.0-rc1+dev118 *Documentation Updates:* nasa/cFE#1598, Updated FS Read/WriteHeader API return documentation nasa/cFE#1601, Document CFE_ES_RunLoop increment task counter behavior nasa/cFE#1602, Document CFE_TBL_Unregister use-case nasa/cFE#1603, Update version description per current design *Standardize docs generation:* nasa/cFE#1615, standardize on "docs" subdirectory nasa/osal#1071, rename doc to docs nasa/PSP#294, rename doc to docs *Coding Standard:* nasa/osal#1042 nasa/PSP#292 **Mutex for UTAssert** nasa/cFE#1596, provide CFE assert lock/unlock nasa/osal#1065, add mutex lock around UtAssert globals *Resolve API-UT discrepancies:* nasa/osal#1055, idmap API nasa/osal#1056, file API nasa/osal#1057, filesys API nasa/osal#1060, socket API nasa/osal#1064, select API **Other cFE Fixes** nasa/cFE#1566, Simplify CFE_FS_SetTimestamp and fix syslog typo nasa/cFE#1592, Removed redundant check/set of CFE_CPU_ID_VALUE nasa/cFE#1593, add time get reference error bit nasa/cFE#1600, Add workflow to build cFE documentation nasa/cFE#1609, Requirements updates nasa/cFE#1610, ES/ResourceID documentation cleanup nasa/cFE#1613, allow multiple sources in add_cfe_coverage_test nasa/cFE#1586, add ES Misc Functional test nasa/cFE#1607, add Mempool functional tests nasa/cFE#1605, Clean/simplify version header and reporting nasa/cFE#1612, doxygen cleanup nasa/cFE#1611, Prepend system log messages with function name **Other osal Fixes** nasa/osal#1063, const correct OS_SelectFdIsSet nasa/osal#1073, Fix OS_Select doxygen errors nasa/osal#1073, Add missing OS_Select param doc nasa/osal#1067, Add Workflow to build and verify OSAL API Guide nasa/osal#1070, add detail design template nasa/osal#1072, Update error codes and documentation nasa/osal#1075, Increase UT object limit for testing Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
cFE Checks https://github.com/nasa/cFE/pull/1619/checks
cFS Bundle Checks https://github.com/nasa/cFS/pull/265/checks
Context
Part of nasa/cFS#265
Authors
@jphickey
@zanzaben
@skliper
@pepepr08
Description
PR #1590
Fix #1483, Add CI workflow to run cFE coverage tests
PR #1598
Fix #1299, Updated FS Read/WriteHeader API return documentation
PR #1601
Fix #567, Document CFE_ES_RunLoop increment task counter behavior
PR #1615
Fix #1614, standardize on "docs" subdirectory
PR #1603
Fix #1177, Update version description per current design
PR #1602
Fix #741, Document CFE_TBL_Unregister use-case
PR #1596
Fix #1595, provide CFE assert lock/unlock
PR #1566
Fix #1442, Simplify CFE_FS_SetTimestamp and fix syslog typo
PR #1592
Fix #1308, Removed redundant check/set of CFE_CPU_ID_VALUE
PR #1593
Fix #1544, add time get reference error bit
PR #1600
Fix #1199, Add workflow to build cFE documentation
PR #1609
Fix #1205 #1131 #1127 #1029 #942 - Requirements updates
PR #1610
Fix #1306, ES/ResourceID documentation cleanup
PR #1613
Fix #1490, allow multiple sources in add_cfe_coverage_test
PR #1586
Fix #814, add ES Misc Functional test
PR #1607
Fix #811, add Mempool functional tests
PR #1605
Fix #1604, Clean/simplify version header and reporting
PR #1612
Fix #1378, 1589, doxygen cleanup
PR #1611
Fix #1325, Prepend system log messages with function name