cFE Integration candidate: 2021-07-20 #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not enforce/add a default extension to binary data files
Fix #1635, Change CI to use Test Log.
astrogeco
changed the title
Fix #1662, remove default .dat extension
Add test cases to exercise all functions, lines, and branches to the extent reasonably possible. Improves the coverage stats significantly: functions 98.9% -> 100% lines 96.4% -> 99.8% branches 87.1% -> 94.9% Remaining uncovered lines/branches are not possible to be reached due to the way the code is structured, or because it would require an alternate implementation of SBR (note that SB+SBR are currently tested as a single unit, even though they are technically separate modules now). For example, the "direct" SBR implementation cannot have collisions, hence the collision handling in SB cannot be reached. Making stubs for SBR may allow this to be tested.
Corrects the return type documentation, on success this function returns the size of the buffer, it does not return CFE_SUCCESS. Additionally, this updates the general description of the pool implementation to reflect the variances in platform architectures (i.e. the buffer descriptor/overhead may be 12 bytes on a CPU with 32 bit size_t, but will be greater on a CPU with a 64 bit size_t).
Fix #1646, Update API doxygen list
Corrects the log message in UT_BSP_Unlock (in cfe_assert module) to match the OSAL function called (OS_MutSemGive).
Fix #1606, update documentation for CFE_ES_GetPoolBufInfo
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jul 21, 2021
**Combines** nasa/cFE#1665, v6.8.0-rc1+dev762 nasa/osal#1113, v5.1.0-rc1+dev573 **Includes** nasa/cFE#1664, remove default .dat extension nasa/cFE#1660, Change CI to use Test Log. nasa/cFE#1670, Update API doxygen list nasa/cFE#1671, update documentation for CFE_ES_GetPoolBufInfo nasa/cFE#1674, CFE_SB_MsgHdrSize returns size_t nasa/cFE#1668, improve SB coverage test nasa/cFE#1694, correct function name in UT_BSP_Unlock nasa/osal#1106, Add independent OS_rename functional test parameter checks Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com> Co-authored-by: Oliver Hamburger <oliverhamburger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Part of nasa/cFS#311
Tests
cFE https://github.com/nasa/cFE/pull/1665/checks
Bundle https://github.com/nasa/cfs/pull/311/checks
Authors
@skliper
@jphickey
@zanzaben
@oliverhamburger
Description
PR #1660
Fix #1635, Change CI to use Test Log.
PR #1664
Fix #1662, remove default .dat extension
PR #1670
Fix #1646, Update API doxygen list
PR #1671
Fix #1606, update documentation for CFE_ES_GetPoolBufInfo
PR #1674
Fix #1667, CFE_SB_MsgHdrSize returns size_t
PR #1668
Fix #471, improve SB coverage test
PR #1694
Fix #1693, correct function name in UT_BSP_Unlock