Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1105, Add independent OS_rename functional test parameter checks #1106

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 15, 2021

Describe the contribution
Fix #1105 - individual parameter checks for OS_rename

Testing performed
Build/run unit tests, passed

Expected behavior changes
None, unit test only

System(s) tested on

  • Hardware: Intel i5/docker
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Jul 15, 2021
@skliper skliper added this to the 6.0.0 milestone Jul 15, 2021
@astrogeco astrogeco requested a review from jphickey July 19, 2021 19:40
@astrogeco astrogeco changed the base branch from main to integration-candidate July 20, 2021 22:50
@astrogeco astrogeco merged commit 660e30b into nasa:integration-candidate Jul 20, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jul 20, 2021
nasa/cFE#1670, Update API doxygen list
nasa/cFE#1671, update documentation for CFE_ES_GetPoolBufInfo
nasa/cFE#1674, CFE_SB_MsgHdrSize returns size_t

nasa/osal#1106, Add independent OS_rename functional test parameter checks
astrogeco added a commit to nasa/cFS that referenced this pull request Jul 21, 2021
**Combines**

nasa/cFE#1665, v6.8.0-rc1+dev762
nasa/osal#1113, v5.1.0-rc1+dev573

**Includes**

nasa/cFE#1664, remove default .dat extension
nasa/cFE#1660, Change CI to use Test Log.
nasa/cFE#1670, Update API doxygen list
nasa/cFE#1671, update documentation for CFE_ES_GetPoolBufInfo
nasa/cFE#1674, CFE_SB_MsgHdrSize returns size_t
nasa/cFE#1668, improve SB coverage test
nasa/cFE#1694, correct function name in UT_BSP_Unlock

nasa/osal#1106, Add independent OS_rename functional test parameter checks

Co-authored-by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored-by: Alex Campbell <zanzaben@users.noreply.github.com>
Co-authored-by: Oliver Hamburger <oliverhamburger@users.noreply.github.com>
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jul 21, 2021
@astrogeco
Copy link
Contributor

CCB:2021-07-21 APPROVED

@skliper skliper deleted the fix1105_rename-param-checks branch October 22, 2021 19:37
jphickey pushed a commit to jphickey/osal that referenced this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS_rename unit test doesn't independently check parameter validity
3 participants