Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1730, Explain FS Header offset & add offset functional tests. #1731

Merged

Conversation

zanzaben
Copy link
Contributor

Describe the contribution
Fixes #1730
Add explanation of offset to the header file. Add functions test for the offset.

Testing performed
Build and run unit test

Expected behavior changes
No impact to behavior

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 29, 2021
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! See suggestion to make the time offset check agnostic to header changes.

modules/cfe_testcase/src/fs_header_test.c Outdated Show resolved Hide resolved
@astrogeco astrogeco requested a review from skliper August 3, 2021 17:16
@astrogeco astrogeco changed the base branch from main to integration-candidate August 4, 2021 14:42
@astrogeco astrogeco merged commit bd0f3dd into nasa:integration-candidate Aug 4, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Aug 4, 2021
@astrogeco
Copy link
Contributor

astrogeco commented Aug 4, 2021

CCB:2021-08-04 APPROVED

  • Helps application developers know what offsets to use

@zanzaben zanzaben deleted the Fix1730_explain_fs_offset branch August 18, 2021 13:49
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly document/test file offset behavior in relation to FS file read/write APIs
3 participants