Fix #2320, reorganize headers #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notably -- with this change, the build system no longer requires the user to maintain a cloned-and-owned copy of the config files in their "defs" directory (e.g. mission_cfg, platform_cfg, etc). The source selection is in place and it will use the supplied default version if no override is given. However, if any override is already present, it will still be used (thus preserving existing configs) |
jphickey
force-pushed
the
fix-2320-reorganize-headers
branch
2 times, most recently
from
8578200
to
06c4bea
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ** mixed-endian environments. This will become obsolete once EDS is | ||
| ** available and the CFE time tone message is defined. | ||
| */ | ||
| #undef CFE_PLATFORM_TIME_CFG_BIGENDIAN |
Check notice
Code scanning / CodeQL-coding-standard
Use of #undef Note
| ** mixed-endian environments. This will become obsolete once EDS is | ||
| ** available and the CFE time tone message is defined. | ||
| */ | ||
| #undef CFE_PLATFORM_TIME_CFG_BIGENDIAN |
Check notice
Code scanning / CodeQL-coding-standard
Disallowed preprocessor use Note
Organize ES header file contents according to the convention
Organize SB header file contents according to the convention
Organize TBL header file contents according to the convention
Organize TIME header file contents according to the convention
Organize EVS header file contents according to the convention
Organize FS header file contents according to the convention
Organize CORE_API header file contents according to the convention
Organize CORE_PRIVATE header file contents according to the convention
jphickey
force-pushed
the
fix-2320-reorganize-headers
branch
from
06c4bea
to
eea6877
Compare
Organize CFE_TESTCASE header file contents according to the convention
Corrects the paths and references in the documentation build to reflect the header name changes. Removes the overrides from "sample_defs" as these are no longer strictly required, user only needs to override if they really need to change something.
jphickey
force-pushed
the
fix-2320-reorganize-headers
branch
from
eea6877
to
4bff797
Compare
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 4, 2023
*Combines:* cFE v7.0.0-rc4+dev304 **Includes:** *cFE* - nasa/cFE#2321 - nasa/cFE#2214 - nasa/cFE#2319 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced May 4, 2023
This is an optional component and thus may not be part of the build. Hotfix based on workflow testing.
jphickey
force-pushed
the
fix-2320-reorganize-headers
branch
from
e89f426
to
ca5106f
Compare
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 4, 2023
*Combines:* cFE v7.0.0-rc4+dev304 **Includes:** *cFE* - nasa/cFE#2321 - nasa/cFE#2214 - nasa/cFE#2319 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 4, 2023
*Combines:* cFE v7.0.0-rc4+dev304 **Includes:** *cFE* - nasa/cFE#2321 - nasa/cFE#2214 - nasa/cFE#2319 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 4, 2023
*Combines:* cFE v7.0.0-rc4+dev304 **Includes:** *cFE* - nasa/cFE#2321 - nasa/cFE#2214 - nasa/cFE#2319 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Reorganizes all the headers in CFE to make them comply with the naming convention as described in the developers guide section 4.2.
Fixes #2320
Testing performed
Build and sanity check CFE in a variety of configurations
Expected behavior changes
Header files are split into smaller parts, more manageable.
Should be backward compatible...
System(s) tested on
Debian
Additional context
The smaller, more granular header files are not only easier to maintain (if maintained by hand) but also are more easily switched to a generated source. It is important to compartmentalize the contents because "source switching" will not work if different types of definitions are mixed in the same header.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.