Fix #2315, uniqueness of tbl target names #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the passed-in table name does not use a qualifier suffix, then generate one by computing a hash of the context information. This ensures that the generated intermediate target names will be unique.
jphickey
force-pushed
the
fix-2315-table-tgt-unique
branch
from
b16a4c0
to
4a11c24
Compare
jphickey
added
the
CCB:Ready
|
Latest update adds some more debug/status info messages when running cmake with "VERBOSE=1" flag set. Ideally, nobody should need to reference the internal target names, but if they do, this flag sheds more light as to what is going on with the internal logic. |
dzbaker
added
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 4, 2023
*Combines:* cFE v7.0.0-rc4+dev304 **Includes:** *cFE* - nasa/cFE#2321 - nasa/cFE#2214 - nasa/cFE#2319 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced May 4, 2023
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 4, 2023
*Combines:* cFE v7.0.0-rc4+dev304 **Includes:** *cFE* - nasa/cFE#2321 - nasa/cFE#2214 - nasa/cFE#2319 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 4, 2023
*Combines:* cFE v7.0.0-rc4+dev304 **Includes:** *cFE* - nasa/cFE#2321 - nasa/cFE#2214 - nasa/cFE#2319 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 4, 2023
*Combines:* cFE v7.0.0-rc4+dev304 **Includes:** *cFE* - nasa/cFE#2321 - nasa/cFE#2214 - nasa/cFE#2319 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
If the passed-in table name does not use a qualifier suffix, then generate one by computing a hash of the context information. This ensures that the generated intermediate target names will be unique.
Fixes #2315
Testing performed
Replicated original error by doing additional "add_cfe_tables" for sample app in local project config, got duplicate name error from CMake. Apply this patch, repeat build, and got all table files successfully.
Expected behavior changes
No more target name conflict
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.