Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse CodeQL, Format Checker, and Static Analysis Workflows #382

Closed
3 tasks done
ArielSAdamsNASA opened this issue Oct 25, 2021 · 0 comments · Fixed by #386 or #390
Closed
3 tasks done

Reuse CodeQL, Format Checker, and Static Analysis Workflows #382

ArielSAdamsNASA opened this issue Oct 25, 2021 · 0 comments · Fixed by #386 or #390

Comments

@ArielSAdamsNASA
Copy link
Contributor

ArielSAdamsNASA commented Oct 25, 2021

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the cFS README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
When needing to change workflows, one must create an issue and PR for each submodule. This feature would reduce duplication.

Describe the solution you'd like
To reuse workflows, the targeted workflow must include workflow_call and inputs as seen below.

on:
  push:
  pull_request:
  workflow_call:
    inputs:
      runs-on: 
        description: Platform to execute on
        type: string
        default: ubuntu-latest

Describe alternatives you've considered
Keep it as is.

Additional context
Tested in OSAL, OSAL cFE CodeQL Reuse Build: https://github.com/ArielSAdamsNASA/osal/runs/4023159610?check_suite_focus=true
Tested in OSAL, OSAL CodeQL Reuse Build: https://github.com/ArielSAdamsNASA/osal/actions/runs/1390702434
cFS CodeQL Reuse: https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/actions/runs/1390561827

Requester Info
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA self-assigned this Oct 25, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 27, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 27, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 27, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 27, 2021
ArielSAdamsNASA pushed a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Oct 27, 2021
ArielSAdamsNASA added a commit that referenced this issue Oct 27, 2021
Revert "Fix #382, Reuse CodeQL, Static Analysis, and Format Check"
astrogeco added a commit to astrogeco/cFS that referenced this issue Dec 6, 2021
Fix nasa#382, Reuse CodeQL, Static Analysis, Format Check
astrogeco added a commit to ArielSAdamsNASA/cFS-JSF-Rules that referenced this issue Dec 6, 2021
Co-authored-by: Ariel Adams <ArielSAdamsNASA@users.noreply.github.com>
astrogeco added a commit to astrogeco/cFS that referenced this issue Dec 6, 2021
Fix nasa#382, Reuse CodeQL, Static Analysis, Format Check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant