Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SurveyModel.get_field_of_regard #52

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

lpsinger
Copy link
Contributor

This is a duplicate of the Mission.get_field_of_regard method.

Please test this before approving.

This is a duplicate of the Mission.get_field_of_regard method.
@lpsinger lpsinger requested a review from mcoughlin April 29, 2021 15:45
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #52 (51b5559) into main (8b9b094) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   26.79%   26.61%   -0.18%     
==========================================
  Files          28       28              
  Lines        1351     1345       -6     
==========================================
- Hits          362      358       -4     
+ Misses        989      987       -2     
Impacted Files Coverage Δ
dorado/scheduling/models.py 36.84% <ø> (-7.16%) ⬇️
dorado/scheduling/scripts/animate_survey.py 5.29% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b9b094...51b5559. Read the comment docs.

Copy link
Collaborator

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down the repo, seemed to work well.

@mcoughlin mcoughlin merged commit 0bcbbaf into nasa:main Apr 29, 2021
@lpsinger lpsinger deleted the refactor-field-of-regard branch April 29, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants