Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lestarch: loosening package requirements #69

Merged
merged 2 commits into from
Jun 10, 2022

Conversation

LeStarch
Copy link
Collaborator

@LeStarch LeStarch commented Jun 3, 2022

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

See: nasa/fprime-tools#78

Copy link
Contributor

@Joshua-Anderson Joshua-Anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most python packages specify a major version of the packages in use (apache airflow). The goal is to prevent users from using incompatible package versions (i.e. super old versions of pytest) without overly constraining users from upgrading the dependencies. I'd recommend going with that approach if possible.

timcanham
timcanham previously approved these changes Jun 7, 2022
@LeStarch LeStarch merged commit f25683a into nasa:devel Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants