lestarch: loosening package requirements #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeStarch
force-pushed
the
update/loose-requirements
branch
from
e902e94
to
b693c0c
Compare
timcanham
previously approved these changes
Jun 6, 2022
LeStarch
force-pushed
the
update/loose-requirements
branch
2 times, most recently
from
45abd5b
to
31dc945
Compare
LeStarch
force-pushed
the
update/loose-requirements
branch
from
31dc945
to
6921cf2
Compare
timcanham
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
The recommended approach for python packages is to ship a
setup.py(a.k.a python package) with the most minimal of requirement specifiers and let PIP to sort out the appropriate version set. This requires loose versions in our packages.To get a "working set" of versions that always works,
fprimewill publish arequirements.txtthat fixes all versions across the project.