Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ComStub and ComQueue #145

Merged
merged 8 commits into from
Jun 8, 2023
Merged

Use ComStub and ComQueue #145

merged 8 commits into from
Jun 8, 2023

Conversation

thomas-bc
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) nasa/fprime#1982
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Introduces ComStub and ComQueue in the new-deployment-generated topology.

Rationale

Addresses nasa/fprime#1982

@thomas-bc thomas-bc requested a review from LeStarch May 31, 2023 20:32
LeStarch
LeStarch requested changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Move up comQueue connection for clarity
  2. Rename uplink and downlink to deframer and framer respectively
  3. Route comStatus through framer
  4. Replace static memory with BufferManager like we did in system reference
  5. Consider "ETC" order

LeStarch
LeStarch requested changes Jun 3, 2023
View reviewed changes
Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just those commented out lines. Otherwise looks good!

...r_templates/cookiecutter-fprime-deployment/{{cookiecutter.deployment_name}}/Top/topology.fpp Outdated Show resolved Hide resolved
@thomas-bc thomas-bc requested a review from LeStarch June 8, 2023 19:25
@thomas-bc thomas-bc merged commit 4e7c6ab into nasa:devel Jun 8, 2023
28 checks passed
@thomas-bc thomas-bc deleted the deployment-comm-stack branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch LeStarch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomas-bc @LeStarch