Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComDriver select for new deployments #159

Merged
merged 4 commits into from
Aug 16, 2023

Conversation

thomas-bc
Copy link
Contributor

Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) nasa/fprime#2191
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Add cookiecutter option to select which type of ComDriver to use for new deployments. Select between UART, TcpClient and TcpServer.

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix types from main/state
  2. Hard-coded allocation size -> Deframer Ring buffer size
  3. Ports should be U16
  4. Ignore UART byte counts

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeStarch LeStarch merged commit c2c4e45 into nasa:devel Aug 16, 2023
28 checks passed
@thomas-bc thomas-bc deleted the feat/comm-selection branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants