Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add documentation for F' subtopologies #2743

Draft
wants to merge 12 commits into
base: devel
Choose a base branch
from

Conversation

mosa11aei
Copy link
Contributor

Related Issue(s) n/a
Has Unit Tests (y/n) n/a
Documentation Included (y/n) y

Change Description

F' subtopologies are a very powerful tool to allow for breaking out one large topology into smaller, more manageable and reusable ones. This PR provides documentation on this tool.

@mosa11aei mosa11aei marked this pull request as ready for review May 24, 2024 18:08
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document should likely be linked in the documentation's navigation/indexes:

Also subtopology and subtopologies should be added to spellcheck: https://github.com/nasa/fprime/blob/devel/.github/actions/spelling/expect.txt

@mosa11aei mosa11aei requested a review from thomas-bc May 28, 2024 17:56
Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the fprime-util new feature (nasa/fprime-tools#203) be documented in this guide?

docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
@mosa11aei
Copy link
Contributor Author

Should the fprime-util new feature (nasa/fprime-tools#203) be documented in this guide?

Up to you. Will that be pushed before the docs?

@mosa11aei
Copy link
Contributor Author

Finally we pass spell check 😁

@mosa11aei mosa11aei requested a review from thomas-bc June 3, 2024 20:20
mosa11aei

This comment was marked as off-topic.

Copy link
Collaborator

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosa11aei this is awesome! I was very much of a noob when it comes to subtopology, and I now feel much more educated!

As a novice, I had a lot of comments/questions. Please just take them as suggestions, this is in no way critical. This is an amazing guide, very clear, the example is really descriptive of the kind of capability subtopologies offers.

Woohoo 🎉

docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
docs/HowTo/develop-subtopologies.md Outdated Show resolved Hide resolved
@thomas-bc thomas-bc linked an issue Jun 4, 2024 that may be closed by this pull request
@LeStarch LeStarch marked this pull request as draft July 1, 2024 22:24
@mosa11aei
Copy link
Contributor Author

@thomas-bc Thanks for your comments, and I apologize for the delay in reviewing them! They should all be addressed.

@thomas-bc @LeStarch according to our discussions, I've written the document to now only use phases. A couple things before this is ready for review and merge:

  1. When should we move the example and tool repo to fprime-community?
  2. Is there enough sufficient push to the tool in the document?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Add Sub-Topology Guide
2 participants