Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add documentation for F' subtopologies #2743
base: devel
Are you sure you want to change the base?
docs: Add documentation for F' subtopologies #2743
Changes from 5 commits
9d709e4
68a24fd
fdbbbae
cefa5a6
a897132
d73814b
b918c4e
5a89fbc
46fac16
bbb8b7d
688f96f
c8b2a78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 1 in docs/HowTo/develop-subtopologies.md
Check failure on line 3 in docs/HowTo/develop-subtopologies.md
Check failure on line 13 in docs/HowTo/develop-subtopologies.md
Check failure on line 30 in docs/HowTo/develop-subtopologies.md
Check failure on line 35 in docs/HowTo/develop-subtopologies.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is multiple subtopologies, do they each include the same TopologyConfig.hpp?
Check failure on line 129 in docs/HowTo/develop-subtopologies.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a markdown table instead? Including some notes on what the names are, e.g. is
MySubtopology_rateGroup
the name of the component instance in C++ land?Check failure on line 219 in docs/HowTo/develop-subtopologies.md
Check failure on line 247 in docs/HowTo/develop-subtopologies.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the order not matter? e.g. MySubtopology before MainDeployment?
Check failure on line 342 in docs/HowTo/develop-subtopologies.md
Check failure on line 342 in docs/HowTo/develop-subtopologies.md