HARMONY-1105: Fix issue with concatenation not being called for the L2-subsetter-to-concise chain. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2-subsetter-to-concise chain.
chris-durbin
requested review from
indiejames,
bilts,
hailiangzhang and
vinnyinverso
indiejames
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1105
Description
L2 subsetter-to-concise chain was not actually submitting a request to concise as part of the chain.
Local Test Steps
http://localhost:3000/C1234208438-POCLOUD/ogc-api-coverages/1.0.0/collections/all/coverage/rangeset?concatenate=true&subset=lat(0%3A90)&maxResults=3
Verify that only one output is created (on main 3 outputs were created)
Open one of the variables in the output with Panoply and see that there are 3 subset index arrays in the output.
PR Acceptance Checklist