actionCollection update event looping when open View Large in Display…

… layout #64 #3959 (#3989)
nasa · Jul 1, 2021 · 0256cc4 · 0256cc4
1 parent 8422add
commit 0256cc4
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/ui/preview/preview-header.vue b/src/ui/preview/preview-header.vue
@@ -103,10 +103,16 @@ export default {
     },
     mounted() {
         if (this.actionCollection) {
+            this.actionCollection.hide(HIDDEN_ACTIONS);
             this.actionCollection.on('update', this.updateActionItems);
             this.updateActionItems(this.actionCollection.getActionsObject());
         }
     },
+    destroyed() {
+        if (this.actionCollection) {
+            this.actionCollection.off('update', this.updateActionItems);
+        }
+    },
     methods: {
         setView(view) {
             this.$emit('setView', view);
@@ -116,7 +122,6 @@ export default {
             delete this.actionCollection;
         },
         updateActionItems() {
-            this.actionCollection.hide(HIDDEN_ACTIONS);
             this.statusBarItems = this.actionCollection.getStatusBarActions();
             this.menuActionItems = this.actionCollection.getVisibleActions();
         },