-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To do list tutorial out of date - bundle not registered on 'Create' list #1309
Comments
I found that I needed to add the bundle to index.html in the openmct script section: |
Did adding the new tutorials/todo bundle to index.html help? |
You have to add it in 2 places... index.html Here is my modified docs/src/tutorials/index.md so far. https://github.com/temecom/openmct/blob/open1309/docs/src/tutorials/index.md It works up to the view: the default view shows up and the tasks aren't Chris On 11/03/2016 11:20 AM, Chandrasekar Sureshkumar wrote:
|
@temecom thanks for your work in open1309 to fix the tutorials. As you've noticed, we've changed how one would install new plugins, but defaultRegistry is not something we would expect people to be modifying. I wanted to give you a few pointers on how we plan to use the new APIs, and in the short term, how we're using them to support old-style bundles but with a slight change to how those bundles are installed. In short, to adapt an old-style bundle to a new style plugin:
We'll be phasing out the legacyRegistry and general "extension" category in favor of clearly documented public APIs, which are starting to take shape in API.md. We'll be converting tutorials to the new API as we work through the process, but if you'd like to update the tutorials to use the new bundle registration strategy that would be much appreciated and a useful stopgap. Let me know if you have any questions! |
Pete, Thanks for the feedback. I guess it depends on how long the next release I found it pretty difficult to get a new bundle up (I still don't have Chris On 11/04/2016 09:47 AM, Pete Richards wrote:
|
Hi Chris-- thanks for your insights. It's been a tough undertaking to rewrite the API while maintaining our existing production developments and as such we have let our documentation get out of date during the transition. The latest master branch is considered stable, but there is missing documentation. What I suggested above is the main change we have made to bundle loading, which I thought was the only difference between the tutorials and master branch, but in reviewing the tutorials myself I see that is not true. Some portions of the API have changed enough that parts of the tutorials simply aren't valid any more. We're planning to release tutorials and documentation for the new API by the end of the year. We've already got a headstart on these new tutorials; we wrote them for the new API when we prototyped it. Now we're finalizing our implementation of the new API; we just have a few small tweaks to make to the new tutorials before we can release them. Do you mind if we touch base in a few weeks and solicit your feedback on our new tutorials? |
Thanks @temecom. I wasn't able to get the todo object working till I read your comments, |
Issues with the tutorials have been resolved by #1339. |
Following the Tutorial for the 'To Do list' fails at the registration:
-- now defaultRegistry.js
-- It shows up in a debug session in legacyRegistry array but does not register as a 'creation' type
-- Evidently something is missing
-- Tried adding bundles.json (suggested in root README) but could not get the path correct
--- It looks for tutorials/todo/bundle.json
The text was updated successfully, but these errors were encountered: