Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Side tree does not stay resized on refresh #1646

Closed
ghost opened this issue Jul 11, 2017 · 6 comments
Closed

[UX] Side tree does not stay resized on refresh #1646

ghost opened this issue Jul 11, 2017 · 6 comments
Labels
bug:regression It used to work. Now it doesn't :( type:bug
Milestone
Target:2.1.6

Comments

@ghost
Copy link

ghost commented Jul 11, 2017 •
edited by ghost

Resizing the tree is necessary (can barely fit the root level) at least on my machine, likely due to hidpi scaling being done automatically. The resize status is not saved anywhere it appears, so I have to resize it manually every time I refresh the page. This gets quite tedious over time.

It would be awesome if this was saved and auto-applied on each refresh. This gif shows the issue live:

Imgur
@ghost ghost changed the title [UX] Side tree does not stay expanded on refresh [UX] Side tree does not stay resized on refresh Jul 11, 2017
@larkin
Copy link
Contributor

larkin commented Jul 31, 2017

@BogdanAlexandru thanks for the report. This behavior is desired for both the tree and the inspector.

When a user resizes the tree by dragging, the resulting size should be stored in localstorage. When a user opens openmct, the size should be read from localstorage. If localstorage doesn't contain a value, then the size should be set the same way it is currently set.

This same behavior should apply to the inspector.

@deeptailor deeptailor self-assigned this Aug 1, 2017
deeptailor added a commit that referenced this issue Aug 2, 2017
@deeptailor
Merge pull request #1659 from dtailor90/master
10b0f43 
persist user preference width for MCTSplitPanes issue #1646, updated MCTSplitPane to handle logic regarding localStorage
deeptailor added a commit that referenced this issue Aug 2, 2017
@deeptailor
Revert "persist user preference width for MCTSplitPanes issue #1646"
b41ceab
larkin added a commit that referenced this issue Aug 2, 2017
@larkin
Merge pull request #1662 from nasa/revert-1659-master
eeb2142 
Revert "persist user preference width for MCTSplitPanes issue #1646"
deeptailor added a commit to deeptailor/openmct that referenced this issue Aug 8, 2017
@deeptailor
Persist User preference widths for MCTSplitPane
065e0a9 
Fix to Issue nasa#1646
Persist MCTSplitPane widths to local storage, thus when user reloads, the Panes maintain dimensions

Changed variables exposed by MCTSplitPane to MCTSplitter to be more specific to use case

Update tests to reflect changes made
deeptailor added a commit to deeptailor/openmct that referenced this issue Aug 16, 2017
@deeptailor
Persist User preference widths for MCTSplitPane
449923f 
Fix to Issue nasa#1646
Persist MCTSplitPane widths to local storage, thus when user reloads, the Panes maintain dimensions
Use persisted widths if available otherwise use default
Add tests for localStorage and fix failing tests
larkin added a commit that referenced this issue Aug 16, 2017
@larkin
Merge pull request #1663 from dtailor90/master
586901a 
persist user preference width for MCTSplitPanes issue #1646
prestonjcrowe pushed a commit that referenced this issue Aug 16, 2017
@deeptailor @prestonjcrowe
Revert "persist user preference width for MCTSplitPanes issue #1646"
0ebe06f
@deeptailor
Copy link
Member

fixed in pr #1663

@ozyx
Copy link
Member

ozyx commented Jan 7, 2023

Reopening as pane positions are no longer persistent since the Vue rewrite

@ozyx ozyx reopened this Jan 7, 2023
@ozyx ozyx assigned ozyx and unassigned deeptailor Jan 7, 2023
@ozyx ozyx added this to the Target:2.1.6 milestone Jan 7, 2023
@ozyx ozyx added the bug:regression It used to work. Now it doesn't :( label Jan 7, 2023
@ozyx ozyx mentioned this issue Jan 9, 2023
Merged
18 tasks
@ozyx
Copy link
Member

ozyx commented Jan 24, 2023

Testing Instructions

  1. Start Open MCT with a fresh localStorage
  2. Reposition the left pane by dragging it
  3. Reposition the right pane by dragging it
  4. Reposition "Recent Objects" pane by dragging it
  5. Refresh
  6. Verify that the position of the panes persist correctly

@michaelrogers
Copy link
Contributor

Fix verified locally during testathon on 2022-02-02. Pane positioning persists through a page refresh.

@khalidadil
Copy link
Contributor

Verified Fixed in Testathon on 02/02/23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( type:bug
Projects
None yet
Milestone
Target:2.1.6
Development

No branches or pull requests
7 participants
@larkin @khalidadil @davetsay @michaelrogers @ozyx @unlikelyzero @deeptailor