Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plot] Options get out of sync during composition re-order, changes made to incorrect item. #2101

Closed
larkin opened this issue Jul 2, 2018 · 0 comments
Closed

[Plot] Options get out of sync during composition re-order, changes made to incorrect item. #2101

larkin opened this issue Jul 2, 2018 · 0 comments
Assignees
@larkin
Labels
type:bug

Comments

@larkin
Copy link
Contributor

larkin commented Jul 2, 2018

If you reorder the composition of a plot, the plot series options will not reorder to match.

Additionally, when you edit series options after reordering, everything appears to work, but then when you save and view the plot, it turns out you were editing a different series.

  1. create overlay plot, add at least two telemetry points.
  2. while editing, re-order telemetry points in composition by drag & dropping.
  3. observe that order of elements in elements pool does not match order in plot series options.
    screen shot 2018-07-02 at 3 11 02 pm
  4. edit plot series option for one of the re-arranged options.
  5. save
  6. note that property was persisted with the wrong plot series option.

Reported in 7/2 testahon from #2066
@larkin larkin added the type:bug label Jul 2, 2018
larkin pushed a commit that referenced this issue Jul 18, 2018
[Plot] separate config index from composition index
2ac4600 
Locate the configuration index by checking identifiers instead of
relying on order of composition to match order of configuration.

Ensures that editing a plot after reordering composition does not
edit wrong object.

Fixes #2101
This was referenced Jul 18, 2018
Merged
Open
@larkin larkin assigned larkin and unassigned deeptailor Jul 20, 2018
psarram pushed a commit that referenced this issue Jul 20, 2018
@larkin @psarram
Plot composition re-ordering support (#2120)
8d21d42 
* [Plot] Allow 0 in plot y axis bounds

Allow 0 values in plot y axis bounds.  Also properly re-do validation
when changing from a bad value to the previously used good value.

Fixes #2082

* [Plot] separate config index from composition index

Locate the configuration index by checking identifiers instead of
relying on order of composition to match order of configuration.

Ensures that editing a plot after reordering composition does not
edit wrong object.

Fixes #2101

* [Plot] refactor form controllers, separate concerns

Refactor form controllers to simplify the plot options inspector.

Individual plot models each have a form controller which handles
three way binding between the scope, model, and domain object configuration.

Added support to linkFields for dynamic object paths so that mutations
always find the right object in the configuration instead of breaking
when indices change.

* support deferred init for sub-object selection

* Style fixes

* Remove assignment to window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larkin larkin

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@larkin @charlesh88 @deeptailor