Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notebook] Example Imagery doesn't capture images #2942

Closed
nikhilmandlik opened this issue Apr 16, 2020 · 4 comments · Fixed by #2943
Closed

[Notebook] Example Imagery doesn't capture images #2942

nikhilmandlik opened this issue Apr 16, 2020 · 4 comments · Fixed by #2943

Comments

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Apr 16, 2020

Related issues:

  1. Notebook Snapshot issues #2940
  2. [Notebook] Notebook Snapshot not capturing some DOM elements #1903

This is CORS content policy restrictions issue.

Ideal Solution: Images response header need to have property Access-Control-Allow-Origin with proper value.

Any image with this property missing ll be blocked by canvas capture due to underlying security concerns.

More info available:

html2canvas:
CORS vs Images/canvas:


Screen Shot 2020-04-15 at 10 37 53 PM

Testing instructions:

ref: snapshot Display Layout -> /stable/#/browse/mine/df4b6619-ea5c-4432-968d-2ca0f3c0debf/d9ebbefc-32ec-4ab6-9d8f-614748a96809?tc.mode=local&tc.startDelta=900000&tc.endDelta=15000&tc.timeSystem=utc&view=layout.view

  1. for comparison try same from images on both /testathon (pass) vs /stable (fail)
  2. Add images into a display layout
  3. Now take a snapshot and open that snapshot
  4. confirm that pass images shows up in snapshot

Images/url for testing:

Name Pass/Fail source url
Space force Pass https://upload.wikimedia.org/wikipedia/commons/thumb/2/29/Seal_of_the_United_States_Space_Force.svg/1200px-Seal_of_the_United_States_Space_Force.svg.png
blade runner 2049 Pass https://images.theconversation.com/files/188582/original/file-20171003-3782-lzbf76.jpg?ixlib=rb-1.1.0&q=45&auto=format&w=926&fit=clip
Nasa logo Fail https://www.nasa.gov/sites/all/themes/custom/nasatwo/images/nasa-logo.svg
Deckard Chases Zhora Fail https://variety.com/wp-content/uploads/2013/05/bladerunner_sequel.jpg
@akhenry
Copy link
Contributor

akhenry commented Aug 10, 2021

@nikhilmandlik Needs test notes.

akhenry added a commit that referenced this issue Aug 10, 2021
Co-authored-by: Andrew Henry <akhenry@gmail.com>
@unlikelyzero unlikelyzero reopened this Aug 24, 2021
@unlikelyzero
Copy link
Collaborator

Re-opening

@unlikelyzero
Copy link
Collaborator

Closing to test in sprint 1.7.8 testathon

@charlesh88
Copy link
Contributor

Verified fixed Testathon 9-20-21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Bug Tracker
Needs triage
Development

Successfully merging a pull request may close this issue.

5 participants