Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Annotation] Should not output to console on cancel #3185

Closed
davetsay opened this issue Jul 13, 2020 · 5 comments · Fixed by #2943
Closed

[Annotation] Should not output to console on cancel #3185

davetsay opened this issue Jul 13, 2020 · 5 comments · Fixed by #2943
Labels
severity:trivial type:bug

Comments

@davetsay
Copy link
Contributor

Expected Behavior

On cancel annotation, console message should not be output

Steps to Reproduce

  1. Make sure browser console is open
  2. Take a snapshot and open by clicking thumbnail
  3. Annotate then click cancel
  4. See that on cancel a message is logged to console (You cancelled the annotation!!!)
johnriedel added a commit to johnriedel/openmct that referenced this issue Jul 25, 2020
@johnriedel
remove console output from annotation cancelation (nasa#3185)
48505e7
@imrishabh18
Copy link

@davetsay Is this issue resolved? Otherwise, I will like to contribute to resolve some beginner issues 😄

@nikhilmandlik
Copy link
Contributor

Is addressed in #2943

@nikhilmandlik nikhilmandlik linked a pull request Oct 13, 2020 that will close this issue
[Notebook] Example Imagery doesn't capture images #2942 #2943
Merged
@jvigliotta
Copy link
Contributor

Testathon - 8/24/2021 : Unable to test due to notebook errors

@unlikelyzero
Copy link
Collaborator

Will retest after #4144 is solved

@charlesh88
Copy link
Contributor

Testathon 8-26-21: verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:trivial type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Notebook] Example Imagery doesn't capture images #2942 nasa/openmct
7 participants
@charlesh88 @nikhilmandlik @davetsay @shefalijoshi @jvigliotta @unlikelyzero @imrishabh18