Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Imagery] Click on image to get a large view #3582

Closed
nikhilmandlik opened this issue Dec 5, 2020 · 6 comments · Fixed by #3770 or #4077
Closed

[Imagery] Click on image to get a large view #3582

nikhilmandlik opened this issue Dec 5, 2020 · 6 comments · Fixed by #3770 or #4077
Assignees
@nikhilmandlik
Labels
type:enhancement

Comments

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Dec 5, 2020 •
edited

Description:

NT1-04 - Click on image to get a large view
From https://docs.google.com/spreadsheets/d/1UF5OyLWYE9x7q56jf6j31JmicKpF-nYC5-OYeOLaghw/edit#gid=0

Testing instructions:

  1. Create or use existing Imagery view.
  2. Click on main image, this should not open in large view.
  3. Create Display layout and add this imagery view into it.
  4. Click on main image (inside a display layout), this should open imagery in a large view.
@nikhilmandlik nikhilmandlik self-assigned this Dec 5, 2020
nikhilmandlik added a commit that referenced this issue Dec 5, 2020
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
92c2845
@nikhilmandlik nikhilmandlik mentioned this issue Dec 5, 2020
Closed
nikhilmandlik added a commit that referenced this issue Dec 7, 2020
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
a0d2065
nikhilmandlik added a commit that referenced this issue Dec 7, 2020
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
a5aa9b5
nikhilmandlik added a commit that referenced this issue Dec 9, 2020
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
fa46176
nikhilmandlik added a commit that referenced this issue Jan 6, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
a255efc
nikhilmandlik added a commit that referenced this issue Mar 29, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
85052f8
@nikhilmandlik nikhilmandlik mentioned this issue Mar 29, 2021
Merged
nikhilmandlik added a commit that referenced this issue May 5, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
d386177
nikhilmandlik added a commit that referenced this issue May 5, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
48c7d5f
nikhilmandlik added a commit that referenced this issue May 13, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
0337d9e
nikhilmandlik added a commit that referenced this issue Jun 21, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
8cf11fe
nikhilmandlik added a commit that referenced this issue Jul 6, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
0ca5cd3
nikhilmandlik added a commit that referenced this issue Jul 20, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
15d1fef
akhenry added a commit that referenced this issue Jul 29, 2021
@nikhilmandlik @akhenry
[Imagery] Click on image to get a large view (#3770)
071a13b 
* [Imagery] Click on image to get a large view #3582
* Created new viewLargeAction.
* Changes in view registry to add parent element property inside view object.
* Separate class for views and added missing changes for LadTableSet.
* Renamed callBack to onItemClicked.

Co-authored-by: Andrew Henry <akhenry@gmail.com>
@jvigliotta
Copy link
Contributor

jvigliotta commented Aug 3, 2021 •
edited

Found an issue:

Screen Shot 2021-08-03 at 10 52 21 AM

I can click ONCE, then close large view, but then can't get it to open again.

@unlikelyzero
Copy link
Collaborator

@nikhilmandlik to take a look at why subsequent clicks are generating the error

nikhilmandlik added a commit that referenced this issue Aug 3, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582
1bde5a5 
fixed issue where large imagery view opens only once.
@nikhilmandlik nikhilmandlik mentioned this issue Aug 3, 2021
Merged
7 tasks
jvigliotta pushed a commit that referenced this issue Aug 4, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582 (#4077)
fe928a1 
fixed issue where large imagery view opens only once.
jvigliotta pushed a commit that referenced this issue Aug 4, 2021
@nikhilmandlik
[Imagery] Click on image to get a large view #3582 (#4085)
1db7ac5 
fixed issue where large imagery view opens only once.
@jvigliotta
Copy link
Contributor

jvigliotta commented Aug 5, 2021 •
edited

Soooooo, it looks like it's working except for the fact that the controls block the ability to click the middle of the image... not sure if that would be a part of this issue though or a separate one.

Yeah, this issue is verified, couldn't find an issue for the arrow's div blocking middle area clicking though.
created issue: #4090

Verified - Testathon - 8/5/2021

@shefalijoshi
Copy link
Contributor

A bit hard to target the area to click on to get the large view in a Display layout, but other than that, stuff works.

@kobe1104
Copy link
Contributor

kobe1104 commented Aug 5, 2021

Verified fixed. Testathon 8/5/2021.

@unlikelyzero
Copy link
Collaborator

@jvigliotta to create a separate issue related to the obscured button

kobe1104 added a commit that referenced this issue Aug 10, 2021
@shefalijoshi @kobe1104 @nikhilmandlik
1.7.6 master merge (#4097)
f42fe78 
* remove can edit from hyperlink (#4076)

* Add check for stop observing before calling it (#4080)

* Set the yKey value on the series when it's changed (#4083)

* [Imagery] Click on image to get a large view #3582 (#4085)

fixed issue where large imagery view opens only once.

Co-authored-by: Henry Hsu <hhsu0219@gmail.com>
Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhilmandlik nikhilmandlik

Labels
type:enhancement
Projects
None yet
Milestone
No milestone
6 participants
@nikhilmandlik @akhenry @shefalijoshi @jvigliotta @unlikelyzero @kobe1104