URL Params to hide tree and inspector

[deeptailor]

We used to have a way to hide the tree and inspector via url params (pre topic core refactor). These were useful for sharing links to other users without distracting them with the tree or the inspector views.

The params used were:

&hideTree=true&hideInspector=true

The url params should be removed upon loading, so the hiding does not carry on down the line
edit: should not remove url params after hiding

We should bring this capability back, as some missions have expressed a need for it.

[rpearce]

Hi, @deeptailor! I've just discovered this project, and I'm happy to help where I can if I can get past node-sass breaking npm i on node 15.11.0 (related? sass/node-sass#2965). What node version do y'all recommend?

Looking at the demo app, is this the result you're going for when those params are present on a page load (before they're removed)?

Tree on left and Inspector on right collapsed

[jvigliotta]

Hi @rpearce if you haven't yet please follow the steps here: #3821 to contribute to the codebase. As for which node version, we recommend 10+. As to your question, yes, that would be the result we're looking for.

Thanks!

[jvigliotta]

HI, @rpearce I'm checking in on CLAs and I haven't seen yours, have you sent it in? If so I'll check to see if it's been received.

[rpearce]

@jvigliotta Thanks for checking in. I haven't sent that in, as I put this to the side when I had the install troubles mentioned above. node-sass has known issues with later versions of node that require an upgrade, and instead of fixing that or downgrading node, I moved on to other projects on my plate (priorities).

That said, this seems to be pretty low-hanging fruit, so I'll send that CLA tomorrow and check back with you here when I do.

[rpearce]

@jvigliotta I've submitted the CLA! Thanks for the follow-up

[jvigliotta]

@rpearce no problem, thanks for sending that in, I'll update once we have that on file!

I do think that this issue may have been picked up in the meantime, but if there is another issue you'd like to take a look at let us know!

[jvigliotta]

@rpearce can confirm, we now have that on file. If there are any other issues you want to take a look at let us know! Thanks!

[davetsay]

@kobe1104 , per our conversation with @charlesh88 and @nikhilmandlik , let's make the state of the application the state of the url. So we should not remove the params hideTree and hideInspector programatically after hiding the panes.

[kobe1104]

Testing instructions:

1. At openmct, add '&hideTree=true' and/or '&hideInspector=true' to the end of the url.

2. The corresponding pane collapses.

3. Refresh the page. The panes from step 2 stay collapsed and the params from step 1 persist.

4. Clicking the collapse button on the panes will add the hide params, and expanding the panes will remove hide params.

5. try opening in new tab and copy paste following to see proper results
   /testathon/#/browse/mine?tc.mode=local&tc.startDelta=900000&tc.endDelta=15000&tc.timeSystem=utc&view=grid&hideTree=true

6. /testathon/#/browse/mine?tc.mode=local&tc.startDelta=900000&tc.endDelta=15000&tc.timeSystem=utc&view=grid&hideInspector=true

[nikhilmandlik]

Verified Fixed.

[jvigliotta]

Verified: Testathon - 8/3/2021