Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 15 Support #2965

Closed
1 of 4 tasks
nschonni opened this issue Sep 18, 2020 · 21 comments
Closed
1 of 4 tasks

Node 15 Support #2965

nschonni opened this issue Sep 18, 2020 · 21 comments
Assignees
@saper @xzyfer @nschonni

Comments

@nschonni
Copy link
Contributor

nschonni commented Sep 18, 2020 •
edited

Version 15 is supposed to be released on October 20th, 2020. Few things that should probably happen to make it smoother going forward:

  • Promote the fixups in the v5 branch
  • Drop testing on unsupported Node versions (<10)
  • Allow people to try and build on old node version, but show warning that we won't support issues opened for those platforms
  • Hold off 3.6 libsass upgrade for separate major release once there is a major version people can pin to
@nschonni nschonni mentioned this issue Sep 26, 2020
Closed
@nschonni nschonni pinned this issue Oct 20, 2020
@nschonni nschonni changed the title Node 15 Support for late October Node 15 Support Oct 20, 2020
@nschonni
Copy link
Contributor Author

@xzyfer I believe the release is expected out today (the 20th). It may just be a matter of restarting the CIs on #2983 or we might have to wait for AppVeyor for the x86 build

@xzyfer
Copy link
Contributor

xzyfer commented Oct 20, 2020

Traditionally we have been blocked on appveyor and Travis to add the new node versions.

@xzyfer
Copy link
Contributor

xzyfer commented Oct 20, 2020

I can build the OSX binaries which will mean we're not blocked on Travis.

@nschonni
Copy link
Contributor Author

I think OSX/Linux should be fine on the GitHub Actions, since they should upload the binaries. I think the gaps will be:

  • Windows x86 on AppVeyor
  • Apline on GitHub Actions will require a new nodejs/docker-node PR and publish on official-images repo
  • FreeBSD binraries from @saper unless we get the Cirrus CI figured out

Remembered that we're actually fully of Travis now, so we're not waiting for that part anymore

@xzyfer
Copy link
Contributor

xzyfer commented Oct 20, 2020 via email

@nschonni
Copy link
Contributor Author

We use the Node.js Alpine images from https://github.com/nodejs/docker-node, which will need to release a v15 version. Once a PR is merged there, it creates another PR to https://github.com/docker-library/official-images, which is then merged and built out on their CI to publish to the Docker Hub

@xzyfer
Copy link
Contributor

xzyfer commented Oct 20, 2020 via email

@nschonni
Copy link
Contributor Author

The Alpine stuff is here https://github.com/sass/node-sass/blob/master/.github/workflows/alpine.yml, it pulls and runs on the "official image" for Node.js. Rest of the Actions use the https://github.com/actions/setup-node/ to install a particular version on Node.js

@xzyfer
Copy link
Contributor

xzyfer commented Oct 20, 2020 via email

@nschonni
Copy link
Contributor Author

nschonni commented Oct 20, 2020 •
edited

@xzyfer so funny story, looks like AppVeyor is actually OK (for the v15 support in the matrix), but all platforms are failing to read the built binary and failing on the test step 😕

PS: PR for the Alpine docker images is nodejs/docker-node#1372

@wiesson
Copy link

wiesson commented Oct 23, 2020

I just wanted to mention that yarn did rebuild node-sass for me without any problems (needed to delete node_modules though)

@dhulme
Copy link

dhulme commented Oct 26, 2020

My build server's docker image (alpine) upgraded to Node 15 and the builds broke because binaries aren't available yet. I've fixed by changing the image to use LTS but would be great to get these binaries out 👍 Thanks!

@nschonni nschonni mentioned this issue Oct 26, 2020
Closed
@nschonni
Copy link
Contributor Author

@xzyfer I've uploaded the binaries built for 0648b5a to https://github.com/sass/node-sass/releases/tag/v5.0.0
Here are the ones still missing:

  • Windows x86. I'm not finding the artifacts for those on AppVeyor. I think they're supposed to be built on tag, but I'm not seeing them
  • Alpine for Node 15. Since the job is failing with the CLI tests, it's not currently uploading that one
  • FreeBSD, will need @saper for 14 & 15 ones, but the previous 10, 12 can probably be re-used

Also dropped mention of Linux x86 from the table since it isn't officially supported on any of those Node versions anymore

@xzyfer
Copy link
Contributor

xzyfer commented Oct 27, 2020

The appveyor build requires a custom build I can kick off later today

@robrich
Copy link

robrich commented Oct 28, 2020

Will there be a node-sass@4.x build for Node 15?

@nschonni
Copy link
Contributor Author

No, it will only be supported in 5 https://github.com/sass/node-sass#node-version-support-policy

@nschonni nschonni mentioned this issue Oct 28, 2020
Closed
@herbievine
Copy link

Is there a v5.x?

@bcksmc
Copy link

bcksmc commented Oct 30, 2020

Can we bump the version number for v5 in package.json? It still says "4.14.1".

I'm happy to submit a PR if that'll help.

@nschonni
Copy link
Contributor Author

That bump will be handled as part of the NPM publish apparently #3012

@nschonni
Copy link
Contributor Author

Closing as v5 is out with Node 15 support. Thanks @xzyfer !

@sass sass locked as resolved and limited conversation to collaborators Oct 31, 2020
@xzyfer
Copy link
Contributor

xzyfer commented Oct 31, 2020

@nschonni you da real mvp

@nschonni nschonni unpinned this issue Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saper saper

@xzyfer xzyfer

@nschonni nschonni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@saper @xzyfer @robrich @wiesson @dhulme @nschonni @herbievine @bcksmc