Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Imagery] Compass element in images set to visible by default #3896

Closed
charlesh88 opened this issue May 27, 2021 · 5 comments · Fixed by #3897
Closed

[Imagery] Compass element in images set to visible by default #3896

charlesh88 opened this issue May 27, 2021 · 5 comments · Fixed by #3897
Labels
severity:critical
Projects
Bug Tracker

Comments

@charlesh88
Copy link
Contributor

During development for #3857, dev code that always sets the compass visibility to true was left in and inadvertently checked in and merged. Line 35 in src/plugins/imagery/components/Compass/Compass.vue was

v-if="hasCameraFieldOfView"

but was incorrectly checked in as

v-if="true"
@charlesh88 charlesh88 self-assigned this May 27, 2021
@charlesh88
Copy link
Contributor Author

Testing Notes

  1. Navigate to an Example Imagery view, or create a new one if needed.
  2. Verify: the compass rose does not display.
  3. Navigate to an "actual" image telemetry view that includes the camera FOV, like the NavCam on hulk
  4. Verify: the compass rose displays as expected.

@charlesh88 charlesh88 mentioned this issue May 27, 2021
Merged
@charlesh88
Copy link
Contributor Author

Partially verified Testathon 6/2/2021 - imagery on banner isn't displaying the compass, but Example Imagery is not displaying the compass as expected.

@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Jun 4, 2021
@unlikelyzero unlikelyzero moved this from Needs triage to Current Sprint in Bug Tracker Jun 4, 2021
@charlesh88
Copy link
Contributor Author

Verified fixed Testathon 6/4/2021

1 similar comment
@jvigliotta
Copy link
Contributor

Verified fixed Testathon 6/4/2021

@nikhilmandlik
Copy link
Contributor

Verified Fixed.

@unlikelyzero unlikelyzero moved this from Current Sprint to Closed in Bug Tracker Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical
Projects
Bug Tracker
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix erroneously checked in dev code for Imagery compass rose nasa/openmct
5 participants
@charlesh88 @nikhilmandlik @shefalijoshi @jvigliotta @unlikelyzero