Allow browser-based context-click to download Imagery #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `pointer-events: none` added to `c-compass` wrapper (which was blocking the image from catching mouse events), and `pointer-events: all` added to `c-direction-rose` element; - Unit tested locally in main view and both types of layouts; - Fixed indention spacing in file;
|
@charlesh88 It looks like the previous and next buttons also prevent the context save menus for images: |
shefalijoshi
requested changes
May 5, 2021
@shefalijoshi Yes, any clickable controls are going to prevent the browser-based menu from displaying - this is normal and can't be solved with this approach. A more long term solution would be to add an explicit Save action, available in the view's 3 dot menu - but let's get this in first. |
|
@shefalijoshi Conflicts resolved, this PR should be good to go. |
Reviewer Checklist
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix to allow browser context-clicking to download imagery. Fixes #3756.
pointer-events: noneadded toc-compasswrapper (which was blocking the image from catching mouse events), andpointer-events: alladded toc-direction-roseelement;