Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked plots need to align the Y axis #3955

Closed
charlesh88 opened this issue Jun 17, 2021 · 3 comments · Fixed by #4286
Closed

Stacked plots need to align the Y axis #3955

charlesh88 opened this issue Jun 17, 2021 · 3 comments · Fixed by #4286

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Jun 17, 2021

Screen Shot 2021-06-17 at 2 42 41 PM

Testing Instructions:

  1. Create 3 SWGs one with very large amplitude value (eg: 100000000)
  2. Create Overlay plot and Add couple of SWG.
  3. Create stack Plot, Add all SWG and observe y axis shifts to adjust new width.
  4. Try to add remove plots from Overlay and Stack plot to observe correct width on y axis.
  5. Also navigate to child SWG inside Stack plot and back to Stacked plot to observe correct width on y axis.
@charlesh88
Copy link
Contributor Author

charlesh88 commented Sep 30, 2021

Testathon 9-30-21: NOT fixed. Alignment works if the user adds end points that need more space, but if a end point is added that needs less space, that item is not sized properly:

image

Replicate:

  1. On banner, make a stacked plot.
  2. In this order, add WheelOdometry > wVelocity, xVelocity, yVelocity.
  3. Observe: yVelocity margin is less than the two proceeding.

Saving, navving away and back does cause the alignment to work properly, but it should update while editing.

@shefalijoshi
Copy link
Contributor

Partially fixed - while actively adding telemetry endpoints the y-axis is still not aligned for multiple endpoints.
Refreshing does align them.

@unlikelyzero unlikelyzero reopened this Sep 30, 2021
Bug Tracker automation moved this from Done to Needs triage Sep 30, 2021
@unlikelyzero unlikelyzero moved this from Needs triage to Will Do in Bug Tracker Sep 30, 2021
@nikhilmandlik nikhilmandlik self-assigned this Oct 1, 2021
@nikhilmandlik nikhilmandlik linked a pull request Oct 1, 2021 that will close this issue
9 tasks
Bug Tracker automation moved this from Will Do to Done Oct 8, 2021
@shefalijoshi
Copy link
Contributor

Verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants