Plot legends are compressing and being clipped when the plot is small

[charlesh88]

Fix plots in Display Layouts to prevent top and bottom legends from being clipped:

[scottbell]

Was able to reproduce, investigating now.

[scottbell]

@charlesh88 Would it be appropriate to set gl-plot-legend min-height to something like 18px? This would at least prevent the top legend from clipping

[scottbell]

Removing myself from this issue to go back to work on
#4196

[nikhilmandlik]

another way to fix is remove overflow: hidden; from .c-plot-legend file 'openmct/src/styles/_legacy-plots.scss'
@charlesh88 any suggestions?

[charlesh88]

@scottbell @nikhilmandlik You guys are both not wrong, but it's a bit more complex than that and we need a better solution than just setting min-height on the legend. There's all sorts of nested scrolling that needs cleaning up. Frankly, it's become kind of a mess over time.

WIP in branch fix-3981.

[davetsay]

needs testing instructions @charlesh88 . I'm not sure what the cut off is to where plot legends should legitimately be clipped or not.

don't know if this is okay or if should show legends in this really small resolution.

[charlesh88]

Something happened in the merge to master, and what's working in branch fix-3981 is not working the same in master. Looking into this, will add testing notes after I determine what happened.

[unlikelyzero]

Waiting for feedback from @charlesh88

[charlesh88]

Testathon 10-29-21: Fix not yet working right for expanded legend, needs more work. Reopening.

[charlesh88]

Testing Notes

1. Put Stacked and Overlay plots into a Display Layout
2. Size the each plot frame so that an internal scrollbar appears, like this:
   
3. Observe: the legend should be visible even though the plot itself may be clipped.
4. Expand the legend: the internal scroll should allow the user to scroll through the whole legend and plot, with each visible in a minimal state.

[akhenry]

Is this a dupe of #3858?

[charlesh88]

Verified fixed Testathon 2023-02-02.

[khalidadil]

Verified Fixed in Testathon on 02/02/23