Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot clicked while in edit mode should open in preview mode #4115

Closed
1 of 5 tasks
nikhilmandlik opened this issue Aug 13, 2021 · 1 comment · Fixed by #4257
Closed
1 of 5 tasks

snapshot clicked while in edit mode should open in preview mode #4115

nikhilmandlik opened this issue Aug 13, 2021 · 1 comment · Fixed by #4257
Labels
severity:critical type:bug
Projects
Bug Tracker

Comments

@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Aug 13, 2021 •
edited

Summary

When clicked on snapshot url/text it navigates to that object url.
But if ui is in edit mode then navigation happens but current view gets replaced by new url. This causes 2 major issues,

  1. current edited view gets dismissed could cause in loss of changes.
  2. new vie may not have edit mode and now is in edit mode. eg: SWG, Clock etc

Expected vs Current Behavior

When in edit mode snapshots should open in preview.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. create or use clock or SWG (non editable object)
  2. take snapshot of object (save in snapshot container)
  3. create or open display layout and click edit (be in edit mode)
  4. now open snapshot container and click on text inside snapshot item (object name and not image)
  5. this should replace display layout with SWG or clock object with edit mode ON

Environment

  • Open MCT Version:
  • Deployment Type:
  • OS:
  • Browser: brave

Additional Information

Screen Shot 2021-08-13 at 12 00 13 PM
@nikhilmandlik nikhilmandlik mentioned this issue Aug 13, 2021
Merged
7 tasks
@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Aug 17, 2021
@nikhilmandlik nikhilmandlik self-assigned this Sep 23, 2021
nikhilmandlik added a commit that referenced this issue Sep 24, 2021
@nikhilmandlik
snapshot clicked while in edit mode should open in preview mode #4115
fc4a8dc
@nikhilmandlik nikhilmandlik mentioned this issue Sep 24, 2021
Merged
8 tasks
@nikhilmandlik nikhilmandlik linked a pull request Sep 24, 2021 that will close this issue
snapshot clicked while in edit mode should open in preview mode #4257
Merged
8 tasks
shefalijoshi pushed a commit that referenced this issue Sep 27, 2021
@nikhilmandlik
snapshot clicked while in edit mode should open in preview mode #4115 (…
c4c1fea 
…#4257)
Bug Tracker automation moved this from Needs triage to Done Sep 27, 2021
@shefalijoshi
Copy link
Contributor

Verified Fixed

shefalijoshi added a commit that referenced this issue Oct 26, 2021
@shefalijoshi @akhenry
@jvigliotta @nikhilmandlik @khalidadil @charlesh88 @scottbell @michaelrogers
1.7.8 master (#4373)
510d3bd 
* Notebook conflict auto retry 1.7.7 (#4230)
* Use timeFormatter.parse to get the timestamp of imagery since the source could be something other than key (#4238)
* If there is a pending create request for an id, queue a duplicate request. (#4243)
* [Telemetry Tables] Handling Request Loading (#4245)

* Fix file selection on pressing enter key (#4246)

* starting loading as false, since that makes sense (#4247)

* Hide independent time conductor mode if only 1 mode option is available. (#4250)

* Fix bargraph color selection (#4253)

* snapshot clicked while in edit mode should open in preview mode #4115 (#4257)

* Fix missing object handling in several vues (#4259)

* Flexible Layouts display Condition Sets as their editing/browsing interface (#4179)

* Flexible Layouts display Condition Sets as their editing/browsing interface #4141

* [Telemetry Table] Progress bar tests (#4249)

* Remove alert styling and hide pause button if in Fixed Time mode. (#4263)

* [Table/Collection Fixes] Clearing correctly, no mutating options, no duplicate requests (#4261)

* Condition sets only persist if actively editing (#4262)

* Imagery views should follow time context (#4264)

* Equal stacked plot y widths for all it's sub-plots (#4267)

* Fix Bar Graph related CSS (#4270)

* Bar graph review comment fixes (#4232)

* Mct4196 - Fixes Conditional Styling not being applied when editing a Condition Widget (#4255)

* Fix plot zoom when child of time strip (#4272)

* Resume plot if no pan, zoom, or drag action is taken (#4138) (#4256)

* [Telemetry Collection] No duplicate requests on load (#4274)

* doing the easy thing first (#4278)

* Bargraph time metadata should consider 'source' (#4289)

* Show clicked image in large view (#4280)

* added icon for inspector (#4275)

* Bar graph style nullcheck (#4291)

* Stacked plots need to align the Y axis  (#4286)

* Duplicate Request Fixes (#4295)

* Add braintree sanitize url lib and sanitize form urls (#4296)

* Mct4177 fix for telemetry endpoints with '.' in the key (#4308)

* Remove additional request to load plots when mounted. (#4314)

* Fix plots dup requests (#4324)

* Merging 1.7.8 into master.

Co-authored-by: Andrew Henry <akhenry@gmail.com>
Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov>
Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov>
Co-authored-by: Khalid Adil <khalidadil29@gmail.com>
Co-authored-by: Charles Hacskaylo <charlesh88@gmail.com>
Co-authored-by: Scott Bell <scott@traclabs.com>
Co-authored-by: Michael Rogers <michael@mhrogers.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity:critical type:bug
Projects
Bug Tracker
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

snapshot clicked while in edit mode should open in preview mode nasa/openmct
4 participants
@charlesh88 @nikhilmandlik @shefalijoshi @unlikelyzero