changing time bounds results in duplicate telemetry requests

[davetsay]

Summary

Two telemetry requests occur when you change bounds from the time conductor.

Expected vs Current Behavior

Duplicate requests happen for each telemetry on bounds change where only one is expected.

Impact Check List

• Data loss or misrepresented data?
• Regression? Did this used to work or has it always been broken?
• Is there a workaround available?
• Does this impact a critical component?
• Is this just a visual bug?

Steps to Reproduce

1. Go to network tab in browser developer tools and clear data
2. navigate to a telemetry endpoint and observe one http request
3. change time bounds and observe two duplicate http requests

Environment

• Open MCT Version:
• Deployment Type:
• OS:
• Browser:

Additional Information

[shefalijoshi]

The issue here is that the button for submitting the form (ref=submitButton) has type="submit"
https://github.com/nasa/openmct/blob/master/src/plugins/timeConductor/Conductor.vue#L41

This will cause the form to submit twice. Changing the button to type="button" and attaching an @click handler to it should help alleviate this problem. Care should be taken to ensure that validation errors/messages continue to work as before if this is done.

[jvigliotta]

Testing Notes

• on the very first visit to Open MCT, click into the start or end inputs for fixed time conductor and press enter (no need to change anything)
• verify the page doesn't refresh
• open a new tab
• visit repeat

[unlikelyzero]

Will retest with Yamcs is not "behaving poorly"

[nikhilmandlik]

Verified Fixed.

[shefalijoshi]

Sometimes I see the page refreshing when making a time conductor change. But I'm not sure how to reliably trigger this.

[unlikelyzero]

Leaving this unverified for another testathon. Please explore the area identified by @shefalijoshi #4167 (comment)

[davetsay]

@jvigliotta assigning to you

[shefalijoshi]

Verified fixed.