Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot notice link not navigating as expected #4194

Closed
2 of 5 tasks
charlesh88 opened this issue Sep 8, 2021 · 3 comments · Fixed by #4199
Closed
2 of 5 tasks

Snapshot notice link not navigating as expected #4194

charlesh88 opened this issue Sep 8, 2021 · 3 comments · Fixed by #4199
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Milestone
Target: 1.8.3

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Sep 8, 2021 •
edited by nikhilmandlik

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. On a server that's not localhost, make a new Notebook and add an entry to make it the default Notebook page.
  2. Go to another view, like a telemetry, and choose the Snapshot option to go directly to the Notebook default:
  3. When the notification appears at the top of the page, click the view link (purple callout):
  4. Expected: you should be navigated to the default Notebook and page. Actual: you are redirected to the My Items folder, and may even be redirected to a different Open MCT instance, depending on where you started.

Environment

  • Open MCT Version: 1.7.7, 1.7.8
  • Deployment Type: /stable, /latest
  • OS: N/A
  • Browser: all
nikhilmandlik added a commit that referenced this issue Sep 9, 2021
@nikhilmandlik
Snapshot notice link not navigating as expected #4194
1e01c19
@nikhilmandlik nikhilmandlik mentioned this issue Sep 9, 2021
Merged
7 tasks
@nikhilmandlik
Copy link
Contributor

nikhilmandlik commented Sep 9, 2021 •
edited

@charlesh88 removed snapshots due to internal url visible. 😅

shefalijoshi added a commit that referenced this issue Sep 14, 2021
@nikhilmandlik @shefalijoshi
Snapshot notice link not navigating as expected #4194 (#4199)
93d967c 
Co-authored-by: Shefali Joshi <simplyrender@gmail.com>
@unlikelyzero unlikelyzero added the bug:regression It used to work. Now it doesn't :( label Jan 7, 2022
@unlikelyzero unlikelyzero added this to the Target: 1.8.4 milestone Jan 7, 2022
nikhilmandlik added a commit that referenced this issue Jan 7, 2022
@nikhilmandlik
Snapshot notice link not navigating as expected #4194
35c76bf
@unlikelyzero unlikelyzero mentioned this issue Jan 7, 2022
Merged
8 tasks
unlikelyzero pushed a commit that referenced this issue Jan 7, 2022
@nikhilmandlik
Snapshot notice link not navigating as expected #4194 (#4686)
187da3c
@unlikelyzero
Copy link
Collaborator

Testing Notes

On a server that's not localhost, make a new Notebook and add an entry to make it the default Notebook page.
Go to another view, like a telemetry, and choose the Snapshot option to go directly to the Notebook default:
When the notification appears at the top of the page, click the view link (purple callout):
Expected: you should be navigated to the default Notebook and page. Actual: you are redirected to the My Items folder, and may even be redirected to a different Open MCT instance, depending on where you started.

@unlikelyzero
Copy link
Collaborator

Verified Fixed

unlikelyzero pushed a commit that referenced this issue Jan 20, 2022
@shefalijoshi @davetsay
@nikhilmandlik @michaelrogers
release 1.8.3 - master (#4752)
dcaad40 
* Fix object creation (#4675)

* Save the object before adding it to the parent so that transaction committing works properly
* Fix object creation - composition policy changes

* use relative path (#4683)

* Notebook Snapshotting to the default Notebook isn't working (#4475)

* Notebook Snapshotting to the default Notebook isn't working #4469

* Check for ref when trying to get the style receiver. (#4687)

Also ensure that the property being displayed in Properties is actually a part of the domainObject.

* Mct 4555 rebased v3 (#4689)

* Preserve the previousFocusedImage for subscription updates, bound change for local and fixed time

* Only preserve previous focused image if paused

* Forcibly reset imageContainer size to prevent aspect ratio distortion

* Remove unneccesary mixin invocation

* Use image history instead of imagehistory size for watcher. Revert other changes

* Added check if last image index is selected

* isPaused instead of paused

Co-authored-by: Michael Rogers <contact@mhrogers.com>

* Snapshot notice link not navigating as expected #4194 (#4686)

* Fix Link Action to accept the right input for validation (#4696)

* Remove snapshot from release version (#4721)

Co-authored-by: David Tsay <3614296+davetsay@users.noreply.github.com>
Co-authored-by: Nikhil <nikhil.k.mandlik@nasa.gov>
Co-authored-by: Michael Rogers <contact@mhrogers.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( severity:critical type:bug
Projects
None yet
Milestone
Target: 1.8.3
Development

Successfully merging a pull request may close this issue.

Snapshot notice link not navigating as expected #4194 nasa/openmct
3 participants
@charlesh88 @nikhilmandlik @unlikelyzero