Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could we somehow use TelemetryCollections to "yield" historical data progressively as pages return? Rather than blocking until everything comes back? #4200

Closed
Tracked by #3980
jvigliotta opened this issue Sep 9, 2021 · 7 comments · Fixed by #4201
Closed
Tracked by #3980

Could we somehow use TelemetryCollections to "yield" historical data progressively as pages return? Rather than blocking until everything comes back? #4200

jvigliotta opened this issue Sep 9, 2021 · 7 comments · Fixed by #4201
Labels
type:enhancement

Comments

@jvigliotta
Copy link
Contributor

jvigliotta commented Sep 9, 2021 •
edited

Name kinda says it all doesn't it?
This was referenced Sep 9, 2021
Closed
Merged
@unlikelyzero
Copy link
Collaborator

@jvigliotta to add testing notes

@charlesh88
Copy link
Contributor

Needs testing notes!

@jvigliotta
Copy link
Contributor Author

Testing

  • view any large telemetry endpoint in fixed time (preferably to really notice)
  • verify that chunks of telemetry are coming in (around 1000 at a time)
  • navigate away with the network tab open, and verify no other requests are mad to the endpoint

@jvigliotta jvigliotta self-assigned this Sep 20, 2021
@akhenry
Copy link
Contributor

akhenry commented Sep 20, 2021

Verified fixed

@akhenry
Copy link
Contributor

akhenry commented Sep 20, 2021

This fix has introduced a bug into some related functionality - #4234

@kobe1104
Copy link
Contributor

Verified fixed testathon 9/20/2021.

@shefalijoshi
Copy link
Contributor

Verified fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
6 participants
@charlesh88 @akhenry @shefalijoshi @jvigliotta @unlikelyzero @kobe1104