Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table data export does not export all available rows #4234

Closed
2 of 5 tasks
akhenry opened this issue Sep 20, 2021 · 5 comments
Closed
2 of 5 tasks

Table data export does not export all available rows #4234

akhenry opened this issue Sep 20, 2021 · 5 comments

Comments

@akhenry
Copy link
Contributor

akhenry commented Sep 20, 2021

Summary

The Export Table Data action will only export the data available in the client, even if there is more data available on the server. This is due to the recent addition of paging support which will asynchronously populate the table with new pages as they are fetched.

Expected vs Current Behavior

Export Table Data should export all available data. The current behavior is that it will export only the data that has been downloaded so far.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Open a telemetry point with telemetry flowing
  2. In the chrome dev tools, go to the network tab.
  3. Throttle the connection to Slow 3G
  4. Set the time conductor to show an hour of data
  5. While the table is slowly refreshing with new data, click on the Export Table Data action from the three-dot menu
  6. Observe that the CSV file exported only contains the rows in the table, and does not contain any of the rows available from the server.

Environment

  • Open MCT Version: 1.7.8

Additional Information

@akhenry
Copy link
Contributor Author

akhenry commented Sep 20, 2021

@charlesh88 @jvigliotta We should discuss potential approaches here. It might be ok to disable the action until all of the data has returned? The user is going to have to wait either way, and waiting for the table to finish loading will be quicker than starting again. Also we have an activity indicator in tables, we don't for the export action.

@unlikelyzero
Copy link
Collaborator

Bumping severity for now

@akhenry
Copy link
Contributor Author

akhenry commented Sep 22, 2021

Closed by #4245

@akhenry akhenry closed this as completed Sep 22, 2021
Bug Tracker automation moved this from Needs triage to Done Sep 22, 2021
@shefalijoshi
Copy link
Contributor

Unable to test since YAMCS was not functioning at the time.

@shefalijoshi
Copy link
Contributor

Verified fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants