Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinch zoom while hovering over plot action buttons should act like pinch zoom while hovering over plot #4353

Closed
2 tasks done
davetsay opened this issue Oct 23, 2021 · 2 comments

Comments

@davetsay
Copy link
Contributor

Summary

When a user hovers over the overlay buttons in plots (eg. zoom in, zoom out, sync time conductor) they leave the plot context. If they then use pinch zoom, not zoom, pinch zoom, the whole browser will zoom since that is the default browser behavior. We should make the buttons part of the plot context.

Expected vs Current Behavior

A user would expect when the cursor is within the boundaries of the plot that the zoom gesture zooms the plot, not the browser. The buttons overlayed on the plot should be considered within the boundaries of the plot.

Impact Check List

  • [] Data loss or misrepresented data?
  • [] Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • [] Is this just a visual bug?

Steps to Reproduce

  1. navigate to a plot
  2. hover over the plot action buttons (eg. zoom in, zoom out, sync time conductor)
  3. pinch zoom

Environment

  • Open MCT Version: master
  • Deployment Type: core
  • OS:
  • Browser:

Additional Information

pinch zoom

@shefalijoshi
Copy link
Contributor

We should think about how zoom/pan fixes will work with Stacked Plots when this is being fixed.

@shefalijoshi
Copy link
Contributor

This might be moot given we're moving actions from buttons to the 3-dot menu.
#4359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants