Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move image export and cursor/grid toggle actions to action menu #4359

Closed
davetsay opened this issue Oct 24, 2021 · 8 comments · Fixed by #5201
Closed

move image export and cursor/grid toggle actions to action menu #4359

davetsay opened this issue Oct 24, 2021 · 8 comments · Fixed by #5201

Comments

@davetsay
Copy link
Contributor

Is your feature request related to a problem? Please describe.
These actions available for plot views takes up an entire row of vertical space.

Describe the solution you'd like
The actions should move to the action menu and exposed in the browse bar (next to snapshot and 3 dot menu)

@trusktr
Copy link
Contributor

trusktr commented Apr 27, 2022

PR: #5125

Screenshots:

Before:

Screenshot 2022-04-26 101652

After:

Screenshot 2022-04-26 184134
Screenshot 2022-04-26 184157

Screenshot 2022-04-26 184235

@trusktr trusktr self-assigned this Apr 27, 2022
@trusktr
Copy link
Contributor

trusktr commented Apr 27, 2022

To test:

  • make an overlay plot
  • notice buttons and toggle switch that were visible between the action bar and the plot are gone
  • notice that the buttons and switch are now in the action bar or the view menu
  • behavior of the buttons should be the same as before

@shefalijoshi
Copy link
Contributor

A small change to the design:

  1. Move the cursor guide and grid toggle to the 'local controls' for a plot (shown on hover), with on/off states
  2. Remove the export image buttons and move them to the 3-dot menu.

@khalidadil
Copy link
Contributor

This looks good to me. I noticed that export to png/jpg is available while editing the object, but they still seem to work as expected. Testathon on 05/24/22.

@rukmini-bose
Copy link
Contributor

Verified Testathon 05/24/2022

@davetsay
Copy link
Contributor Author

I'm seeing a weird rendering artifact when hovering on the actions in the 3 dot menu. There is flickering and then at points there are grey bars.

Screen Shot 2022-05-24 at 2 55 52 PM

@charlesh88
Copy link
Contributor

Verified fixed Testathon 6-9-22

@rukmini-bose
Copy link
Contributor

Verified Testathon 6/9/2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants