Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving an object in a Display Layout and clicking off causes it to snap back to previous position #4385

Closed
2 of 5 tasks
khalidadil opened this issue Oct 27, 2021 · 13 comments · Fixed by #4388 or #4421
Closed
2 of 5 tasks
Labels
bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue severity:blocker type:bug
Projects
Milestone

Comments

@khalidadil
Copy link
Contributor

khalidadil commented Oct 27, 2021

Summary

I'm seeing an issue where moving an object in a display layout and clicking off the object causes it to move back to the original position.

Expected vs Current Behavior

The moved object should stay in the new location and not move back.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug?

Steps to Reproduce

  1. Create a Display Layout and add an object to it, like a sine wave generator, and save the display layout.
  2. Edit the display layout and move the new object. Click off the object to deselect it.
  3. When the object is deselected, it will move back to the original position.

Environment

  • Open MCT Version: 1.8.0
  • Deployment Type: testathon
  • OS: MacOS Big Sur
  • Browser: Chrome

Additional Information

Screen.Recording.2021-10-27.at.11.49.25.AM.mov
@unlikelyzero unlikelyzero added the bug:visual Visual problem. Not a functional issue label Oct 27, 2021
@unlikelyzero
Copy link
Collaborator

@khalidadil to add additional comments

@nikhilmandlik to investigate this issue along with the transaction API changes

@unlikelyzero unlikelyzero added this to Needs triage in Bug Tracker via automation Oct 27, 2021
@shefalijoshi
Copy link
Contributor

Hiding frames for objects in a display layout and clicking away also gets reverted.

@khalidadil
Copy link
Contributor Author

khalidadil commented Oct 27, 2021

I also noticed that adding an object, like an ellipse, and removing it also doesn't work. I'm assuming that is part of the same transaction issue on mutations. If not, that should be broken out into another issue.

@shefalijoshi
Copy link
Contributor

#4388 Likely fixes these issues too.

@akhenry akhenry closed this as completed Oct 28, 2021
Bug Tracker automation moved this from Needs triage to Done Oct 28, 2021
@charlesh88
Copy link
Contributor

charlesh88 commented Oct 29, 2021

Verified POSSIBLY NOT fixed Testathon 10/29/21 on /testathon - still see the described behavior, albeit in an older Display Layout. Cannot verify in new layout due to issues noted in #4089

@khalidadil
Copy link
Contributor Author

I'm still seeing this issue as well - Testathon 10/29/21

@unlikelyzero unlikelyzero reopened this Oct 29, 2021
Bug Tracker automation moved this from Done to Needs triage Oct 29, 2021
@unlikelyzero unlikelyzero added bug:regression It used to work. Now it doesn't :( severity:blocker and removed severity:critical labels Nov 1, 2021
@unlikelyzero unlikelyzero moved this from Needs triage to Will Do in Bug Tracker Nov 1, 2021
@akhenry
Copy link
Contributor

akhenry commented Nov 1, 2021

It appears that clicking in display layouts is triggering an object refresh, which it shouldn't.

@nikhilmandlik nikhilmandlik self-assigned this Nov 1, 2021
@nikhilmandlik nikhilmandlik mentioned this issue Nov 2, 2021
8 tasks
@unlikelyzero unlikelyzero added this to the Target: 1.8.1 milestone Nov 3, 2021
Bug Tracker automation moved this from Will Do to Done Nov 15, 2021
@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Nov 15, 2021

Testing Notes

#4385 (comment)

and

  • Create a Display Layout and add an object to it, like a sine wave generator, and save the display layout.
  • Edit the display layout and move the new object. Click off the object to deselect it.
  • When the object is deselected, it will move back to the original position.

@khalidadil
Copy link
Contributor Author

Verified Fixed in Testathon on 11/15/2021

@davetsay
Copy link
Contributor

verified

@charlesh88
Copy link
Contributor

Verified fixed Testathon 11-15-21.

@akhenry
Copy link
Contributor

akhenry commented Nov 15, 2021

Verified Fixed. Nice one!

@shefalijoshi
Copy link
Contributor

Verified fixed! Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:regression It used to work. Now it doesn't :( bug:visual Visual problem. Not a functional issue severity:blocker type:bug
Projects
8 participants