Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all remaining usage of the legacy dialogService under /src/ #4551

Closed
akhenry opened this issue Dec 8, 2021 · 2 comments · Fixed by #4564
Closed

Replace all remaining usage of the legacy dialogService under /src/ #4551

akhenry opened this issue Dec 8, 2021 · 2 comments · Fixed by #4564
Assignees
@nikhilmandlik
Labels
severity:critical type:maintenance tests, chores, or project maintenance
Projects
Remove AngularJS
Milestone
Target: 1.8.2

Comments

@akhenry
Copy link
Contributor

akhenry commented Dec 8, 2021 •
edited by nikhilmandlik

Summary

There is still some usage of the legacy dialogService and injector in code under the /src/ folder. This should be replaced with equivalent calls to openmct.overlay....

It is also a part of form refactor fix

Testing Instructions:

  1. Create a Display Layout and add Text and Image items to it
  2. try to edit Text and rename to something else (refresh page and confirm rename persist)
  3. try to edit image url (refresh page and confirm new image url persist)
@akhenry akhenry added the type:maintenance tests, chores, or project maintenance label Dec 8, 2021
@akhenry akhenry changed the title Replace all remaining usage of the dialogService under /src/ Replace all remaining usage of the legacy dialogService under /src/ Dec 8, 2021
@akhenry akhenry mentioned this issue Dec 8, 2021
Closed
16 tasks
@unlikelyzero unlikelyzero added this to To do in Remove AngularJS via automation Dec 8, 2021
nikhilmandlik added a commit that referenced this issue Dec 11, 2021
@nikhilmandlik
Replace all remaining usage of the legacy dialogService under /src/ #…
980e442 
…4551
@nikhilmandlik nikhilmandlik mentioned this issue Dec 11, 2021
Merged
8 tasks
Remove AngularJS automation moved this from To do to Done Dec 13, 2021
akhenry pushed a commit that referenced this issue Dec 13, 2021
@nikhilmandlik
Legacy dialogservice form fix (#4564)
82ea23e 
* Replace all remaining usage of the legacy dialogService under /src/ #4551
* fixed DefaultRootNamePlugin tests
* fix importFromJSONAction tests
@unlikelyzero unlikelyzero added this to the Target: 1.8.2 milestone Dec 13, 2021
@jvigliotta
Copy link
Contributor

Verified Fixed - Testathon: 12/13/2021

I wasn't able to edit the image url, but I may just not know how to do so.

@unlikelyzero
Copy link
Collaborator

Verified with https://placekitten.com/200/300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhilmandlik nikhilmandlik

Labels
severity:critical type:maintenance tests, chores, or project maintenance
Projects
No open projects
Remove AngularJS
Done
Milestone
Target: 1.8.2
Development

Successfully merging a pull request may close this issue.

Legacy dialogservice form fix nasa/openmct
4 participants
@nikhilmandlik @akhenry @jvigliotta @unlikelyzero