Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Remove Zepto dependency #4665

Closed
2 tasks done
unlikelyzero opened this issue Jan 4, 2022 · 4 comments
Closed
2 tasks done

[Build] Remove Zepto dependency #4665

unlikelyzero opened this issue Jan 4, 2022 · 4 comments
Labels
type:maintenance tests, chores, or project maintenance

Comments

@unlikelyzero
Copy link
Collaborator

unlikelyzero commented Jan 4, 2022

Summary

We have some vestigial organs related to "Zepto" throughout openmct.

  • Remove references to Zepto
  • Remove exports-loader from dependencies
@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Jan 4, 2022
@akhenry
Copy link
Contributor

akhenry commented Jan 10, 2022

In what time frame is this needed? Almost all current usage of zepto is in legacy or deprecated code that will be going away over the next few months anyway.

Here's where we're using it right now -

  • A bunch of usage under /platform as a more performant alternative to Angular's $ function (which was a stripped down JQuery analog). This will all go away when we drop Angular and our legacy codebase.
  • Summary Widgets. These have been deprecated and replaced with Condition Sets + Condition Widgets. Summary Widgets will be removed completely in the coming months.
  • This just leaves some usage in indicators, and the Autoflow tabular plugin, which we should replace with native API calls.

I'll create an issue to address any non-legacy usage so we can get started on that immediately.

@akhenry akhenry changed the title [Build] Remove references to "Zepto" [Build] Remove Zepto dependency Jan 10, 2022
@unlikelyzero
Copy link
Collaborator Author

@akhenry my initial concern was that exports-loader is incredibly out of date. I don't think there's any sort of clear need for this before Build 7.

@unlikelyzero unlikelyzero added this to the Build7 milestone Jan 10, 2022
@unlikelyzero unlikelyzero added this to To do in Remove AngularJS via automation Jan 10, 2022
@akhenry
Copy link
Contributor

akhenry commented Jan 10, 2022

OK, understood, thanks.

@akhenry
Copy link
Contributor

akhenry commented Jul 11, 2022

@akhenry akhenry closed this as completed Jul 11, 2022
Remove AngularJS automation moved this from To do to Done Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
No open projects
Development

No branches or pull requests

2 participants