Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all non-legacy usage of Zepto #4698

Closed
akhenry opened this issue Jan 10, 2022 · 6 comments · Fixed by #5159
Closed

Remove all non-legacy usage of Zepto #4698

akhenry opened this issue Jan 10, 2022 · 6 comments · Fixed by #5159

Comments

@akhenry
Copy link
Contributor

akhenry commented Jan 10, 2022

Is your feature request related to a problem? Please describe.
Zepto is a performant drop-in replacement for JQuery and Angular's $ function. It was used pretty extensively in our legacy codebase, but there is also some usage in our current codebase.

Describe the solution you'd like
All usage of zepto in our current codebase (ie. everything under /src/) should be replaced with native JavaScript API calls.

The following usage of Zepto in non-deprecated code shoulld be removed:

Additional context
There is also usage of Zepto in our legacy codebase (ie. under "platform"), and in Summary Widgets but this code is deprecated and will be removed under a separate task.

@unlikelyzero
Copy link
Collaborator

We should also remove exports-loader as a part of this PR

@akhenry
Copy link
Contributor Author

akhenry commented Jun 2, 2022

Testing Notes (taken from #5159 (comment))

Plugins affected:

Summary Widget
URL Indicator Plugin

To test, all functionality of the listed plugins should remain the same prior to these changes.

'Add condition' functionality under summary widget is bugged prior to these changes. At a glance, the refreshConditions function does not seem to be using the updated config object from the corresponding initCondition function in the Rule.js file.

@akhenry
Copy link
Contributor Author

akhenry commented Jun 2, 2022

Note that we may need to temporarily re-enable the creation of summary widgets to test this.

@khalidadil
Copy link
Contributor

We need to enable summary widgets to test this issue.

@unlikelyzero
Copy link
Collaborator

Will need to create a local viper-openmct install based on release/2.0.5 with summary widgets enabled

@akhenry
Copy link
Contributor Author

akhenry commented Jul 7, 2022

Verified fixed by importing attached JSON file that includes a summary widget. No need to enable creation of summary widgets
Summary Widget.json.zip

@akhenry akhenry removed the unverified label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants