Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form validation error messages are not being displayed properly #4697

Closed
2 of 5 tasks
charlesh88 opened this issue Jan 8, 2022 · 1 comment · Fixed by #4887
Closed
2 of 5 tasks

Form validation error messages are not being displayed properly #4697

charlesh88 opened this issue Jan 8, 2022 · 1 comment · Fixed by #4887
Labels
bug:regression It used to work. Now it doesn't :( needs:e2e Needs an e2e test severity:critical type:bug
Milestone
Target:2.0.2

Comments

@charlesh88
Copy link
Contributor

Summary

Form validation error messages which used to display as browser-rendered HTML5 error message bubble callouts are being shown as <title> attribute tooltips instead:

image

This is bad as the user needs to hover over the field to see how to repair the problem. This gesture is not standard or expected in this case.

Expected vs Current Behavior

Form validation errors should display as browser-rendered HTML5 error message bubble callouts:

image

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Steps to Reproduce

  1. Enter a Start Time in the Time Conductor that's after the End Time.
  2. Observe: no built-in error messaging is displayed.

Environment

  • Open MCT Version: 1.8.3-SNAPSHOT b3ab56c
  • Deployment Type: local
  • OS: Mac
  • Browser: Chrome

Additional Information

image
@unlikelyzero unlikelyzero added the needs:e2e Needs an e2e test label Jan 8, 2022
@charlesh88 charlesh88 mentioned this issue Jan 10, 2022
Merged
15 tasks
@akhenry
Copy link
Contributor

akhenry commented Jan 29, 2022 •
edited

Investigation note: this is a regression, the time conductor was implemented using HTML5 validation.

@akhenry akhenry removed their assignment Jan 29, 2022
@akhenry akhenry added Target:1.8.5 bug:regression It used to work. Now it doesn't :( labels Jan 29, 2022
nikhilmandlik added a commit that referenced this issue Feb 23, 2022
@nikhilmandlik
Form validation error messages are not being displayed properly #4697
6c311b4
@nikhilmandlik nikhilmandlik mentioned this issue Feb 23, 2022
Merged
15 tasks
unlikelyzero pushed a commit that referenced this issue Mar 16, 2022
@nikhilmandlik @jvigliotta @johnhill2
Form validation error messages are not being displayed properly (#4887)
e9680e9 
* Form validation error messages are not being displayed properly #4697

* e2e Tests

* fixed element.checkValidity test

* remove comment

* adding timeconductor tests

* rename

Co-authored-by: Jamie V <jamie.j.vigliotta@nasa.gov>
Co-authored-by: unlikelyzero <jchill2@gmail.com>
@unlikelyzero unlikelyzero added this to the Target:2.0.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:regression It used to work. Now it doesn't :( needs:e2e Needs an e2e test severity:critical type:bug
Projects
None yet
Milestone
Target:2.0.2
Development

Successfully merging a pull request may close this issue.

Form validation error messages are not being displayed properly nasa/openmct
3 participants
@charlesh88 @akhenry @unlikelyzero