Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestrip View doesn't display Plans properly #4810

Closed
2 of 5 tasks
charlesh88 opened this issue Jan 28, 2022 · 3 comments · Fixed by #4815
Closed
2 of 5 tasks

Timestrip View doesn't display Plans properly #4810

charlesh88 opened this issue Jan 28, 2022 · 3 comments · Fixed by #4815

Comments

@charlesh88
Copy link
Contributor

charlesh88 commented Jan 28, 2022

Summary

Title says it all. Have a look:

Screen Shot 2022-01-24 at 10 53 40 AM

This is probably due to a broken CSS selector stemming from updated markup. @shefalijoshi I'll take a look first and ping you if it's something I can't figure out.

Expected vs Current Behavior

Title says it all.

Impact Check List

  • Data loss or misrepresented data?
  • Regression? Did this used to work or has it always been broken?
  • Is there a workaround available?
  • Does this impact a critical component?
  • Is this just a visual bug with no functional impact?

Steps to Reproduce

  1. Add a plan from the tree to a Timestrip view.
  2. Observe that the result is the same as the screenshot at the top of this issue.

Environment

  • Open MCT Version: 1.8.3 / 1.8.4
  • Deployment Type: /stable /testathon
  • OS: Mac
  • Browser: Chrome

Additional Information

@charlesh88 charlesh88 changed the title Timestrip View doesn't display plans properly Timestrip View doesn't display Plans properly Jan 28, 2022
@charlesh88
Copy link
Contributor Author

Problem found, but solution not yet clear. Sometime after 1.8.2, we changed the strategy behind how Plans are added to Timestrips in a way that kills the grid layout:

Screen Shot 2022-01-31 at 4 17 45 PM

What we need to do is

  1. Know when a Plan is inside c-object-view and
  2. Write CSS that selects appropriately for that.

charlesh88 added a commit that referenced this issue Feb 1, 2022
- Add objectTypeClass property to allow new CSS selector to target Plan object types in Timestrip views.;
@charlesh88
Copy link
Contributor Author

Testing Instructions

  1. Create or edit a Timestrip view.
  2. Add a Plan view to the Timestrip view. Add another object view like a telemetry point or Sine Wave Generator.
  3. Verify the Plan does NOT appear as the first screenshot in this issue, but instead looks something like this:

Screen Shot 2022-02-01 at 10 48 50 AM

or this
Screen Shot 2022-02-01 at 10 54 17 AM

  1. Check for regressions: click the Plan view itself in the tree, and verify it looks something like this:

Screen Shot 2022-02-01 at 10 48 54 AM

@charlesh88 charlesh88 mentioned this issue Feb 1, 2022
15 tasks
shefalijoshi added a commit that referenced this issue Feb 7, 2022
- Add objectTypeClass property to allow new CSS selector to target Plan object types in Timestrip views.;

Co-authored-by: Shefali Joshi <simplyrender@gmail.com>
@unlikelyzero unlikelyzero added this to the Target: 1.8.5 milestone Feb 14, 2022
@shefalijoshi
Copy link
Contributor

Verified fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants